public inbox for [email protected]  
help / color / mirror / Atom feed
typo in release note
5+ messages / 4 participants
[nested] [flat]

* typo in release note
@ 2010-06-10 08:00  Fujii Masao <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Fujii Masao @ 2010-06-10 08:00 UTC (permalink / raw)
  To: pgsql-docs

Hi,

The release note says "Allow continuous archive (WAL) files
to be streamed to a standby system" about SR. But no archive
files are streamed in SR. So we should get rid of the word
"archive" from that sentence? Here is the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Attachments:

  [application/octet-stream] release_note_typo_sr_v1.patch (936B, 2-release_note_typo_sr_v1.patch)
  download | inline diff:
*** a/doc/src/sgml/release-9.0.sgml
--- b/doc/src/sgml/release-9.0.sgml
***************
*** 39,45 **** recovery_connections -> hot_standby
  
      <listitem>
       <para>
!       Allow continuous archive (<acronym>WAL</>) files to be streamed to a
        standby system
       </para>
      </listitem>
--- 39,45 ----
  
      <listitem>
       <para>
!       Allow continuous <acronym>WAL</> files to be streamed to a
        standby system
       </para>
      </listitem>
***************
*** 391,397 **** recovery_connections -> hot_standby
  
       <listitem>
        <para>
!        Allow continuous archive (<acronym>WAL</>) files to be streamed to a
         standby system (Fujii Masao, Heikki Linnakangas)
        </para>
  
--- 391,397 ----
  
       <listitem>
        <para>
!        Allow continuous <acronym>WAL</> files to be streamed to a
         standby system (Fujii Masao, Heikki Linnakangas)
        </para>
  


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: typo in release note
@ 2010-06-10 13:06  Robert Haas <[email protected]>
  parent: Fujii Masao <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Robert Haas @ 2010-06-10 13:06 UTC (permalink / raw)
  To: Fujii Masao <[email protected]>; +Cc: pgsql-docs

On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <[email protected]> wrote:
> The release note says "Allow continuous archive (WAL) files
> to be streamed to a standby system" about SR. But no archive
> files are streamed in SR. So we should get rid of the word
> "archive" from that sentence? Here is the patch.

I don't think that reads very well.  Possibly we could remove
"continuous archive" as a whole, but I don't think we can remove one
word and keep the other.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: typo in release note
@ 2010-06-10 14:16  Tom Lane <[email protected]>
  parent: Robert Haas <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2010-06-10 14:16 UTC (permalink / raw)
  To: Robert Haas <[email protected]>; +Cc: Fujii Masao <[email protected]>; pgsql-docs

Robert Haas <[email protected]> writes:
> On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <[email protected]> wrote:
>> The release note says "Allow continuous archive (WAL) files
>> to be streamed to a standby system" about SR. But no archive
>> files are streamed in SR. So we should get rid of the word
>> "archive" from that sentence? Here is the patch.

> I don't think that reads very well.  Possibly we could remove
> "continuous archive" as a whole, but I don't think we can remove one
> word and keep the other.

I'm inclined to think that "continuous archiving" was meant.  At least
that's the phrase that is used in chapter 24.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: typo in release note
@ 2010-06-10 14:29  Robert Haas <[email protected]>
  parent: Tom Lane <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Robert Haas @ 2010-06-10 14:29 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Fujii Masao <[email protected]>; pgsql-docs

On Thu, Jun 10, 2010 at 10:16 AM, Tom Lane <[email protected]> wrote:
> Robert Haas <[email protected]> writes:
>> On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <[email protected]> wrote:
>>> The release note says "Allow continuous archive (WAL) files
>>> to be streamed to a standby system" about SR. But no archive
>>> files are streamed in SR. So we should get rid of the word
>>> "archive" from that sentence? Here is the patch.
>
>> I don't think that reads very well.  Possibly we could remove
>> "continuous archive" as a whole, but I don't think we can remove one
>> word and keep the other.
>
> I'm inclined to think that "continuous archiving" was meant.  At least
> that's the phrase that is used in chapter 24.

Yeah, probably - but I think what Fujii-san is concerned about is
whether streaming replication is a subset of continuous archiving -
the files never actually get "archived".

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: typo in release note
@ 2010-07-01 02:33  Bruce Momjian <[email protected]>
  parent: Robert Haas <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: Bruce Momjian @ 2010-07-01 02:33 UTC (permalink / raw)
  To: Robert Haas <[email protected]>; +Cc: Tom Lane <[email protected]>; Fujii Masao <[email protected]>; pgsql-docs

Robert Haas wrote:
> On Thu, Jun 10, 2010 at 10:16 AM, Tom Lane <[email protected]> wrote:
> > Robert Haas <[email protected]> writes:
> >> On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <[email protected]> wrote:
> >>> The release note says "Allow continuous archive (WAL) files
> >>> to be streamed to a standby system" about SR. But no archive
> >>> files are streamed in SR. So we should get rid of the word
> >>> "archive" from that sentence? Here is the patch.
> >
> >> I don't think that reads very well. ?Possibly we could remove
> >> "continuous archive" as a whole, but I don't think we can remove one
> >> word and keep the other.
> >
> > I'm inclined to think that "continuous archiving" was meant. ?At least
> > that's the phrase that is used in chapter 24.
> 
> Yeah, probably - but I think what Fujii-san is concerned about is
> whether streaming replication is a subset of continuous archiving -
> the files never actually get "archived".

Fujii-san is absolutely right.  The original wording assumed streaming
replication and hot standby were a subset of continuous archiving, but I
later realized that you do not need to enable continuous archiving to do
use them, particularly with a sufficiently large wal_keep_segments:

	http://momjian.us/main/blogs/pgblog/2010.html#June_16_2010

Attached patch applied.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +


Attachments:

  [text/x-diff] /rtmp/diff (1.2K, 2-%2Frtmp%2Fdiff)
  download | inline diff:
Index: doc/src/sgml/release-9.0.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/release-9.0.sgml,v
retrieving revision 2.37
diff -c -c -r2.37 release-9.0.sgml
*** doc/src/sgml/release-9.0.sgml	30 Jun 2010 14:25:24 -0000	2.37
--- doc/src/sgml/release-9.0.sgml	1 Jul 2010 02:29:52 -0000
***************
*** 398,404 ****
      <itemizedlist>
       <listitem>
        <para>
!        Allow continuous archive standby systems to accept read-only queries
         (Simon Riggs, Heikki Linnakangas)
        </para>
  
--- 398,404 ----
      <itemizedlist>
       <listitem>
        <para>
!        Allow a standby system to accept read-only queries
         (Simon Riggs, Heikki Linnakangas)
        </para>
  
***************
*** 412,418 ****
  
       <listitem>
        <para>
!        Allow continuous archive (<acronym>WAL</>) files to be streamed to a
         standby system (Fujii Masao, Heikki Linnakangas)
        </para>
  
--- 412,418 ----
  
       <listitem>
        <para>
!        Allow write-ahead log (<acronym>WAL</>) files to be streamed to a
         standby system (Fujii Masao, Heikki Linnakangas)
        </para>
  


^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2010-07-01 02:33 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-06-10 08:00 typo in release note Fujii Masao <[email protected]>
2010-06-10 13:06 ` Robert Haas <[email protected]>
2010-06-10 14:16   ` Tom Lane <[email protected]>
2010-06-10 14:29     ` Robert Haas <[email protected]>
2010-07-01 02:33       ` Bruce Momjian <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox