From: PG Doc comments form <noreply@postgresql.org>
To: pgsql-docs@lists.postgresql.org
Cc: ruslan.fomkin@gmail.com
Subject: SPI_finish in the case of ereport
Date: Tue, 20 Aug 2019 09:45:21 +0000
Message-ID: <156629432107.1308.3753759498779162858@wrigleys.postgresql.org> (raw)
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/11/spi-spi-finish.html
Description:
Hi,
The documentation of SPI_finish clarifies that aborting with elog will
cleanup SPI automatically without need to call to SPI_finish manually, see
https://www.postgresql.org/account/comments/new/11/spi-spi-finish.html/
On the other side the error reporting is normally done by ereport, while
elog is an old function, which is interchangeable with `ereport` according
to https://www.postgresql.org/docs/11/error-message-reporting.html
If so, can the documentation of SPI_finish mention ereport instead of elog?
(it would be also nice if a regression test is added for this)
Best regards,
Ruslan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: noreply@postgresql.org, pgsql-docs@lists.postgresql.org, ruslan.fomkin@gmail.com
Subject: Re: SPI_finish in the case of ereport
In-Reply-To: <156629432107.1308.3753759498779162858@wrigleys.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox