public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Justin Pryzby <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: systemd service start - disable timeout with "infinity"
Date: Sun, 20 Mar 2022 15:45:09 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

Justin Pryzby <[email protected]> writes:
> On Sun, Mar 20, 2022 at 12:11:19PM -0400, Tom Lane wrote:
>> Hmm ... maybe zero works too, or worked when this was written?
>> But you're right that "infinity" is now the documented way
>> to do it.  Will fix, thanks for the report.

> +# 0 is the same as infinity, but "infinity" needs systemd 229

Ah, thanks for the data point.  229 is far enough back that
I'm not too troubled about that; besides, since this is just
a documentation example, clarity is more important.

BTW, what I read in the systemd docs is that TimeoutSec is
a shorthand for setting both TimeoutStartSec and TimeoutStopSec,
so the code in our RPMs looks a bit dubious now:

 # Do not set any timeout value, so that systemd will not kill postmaster
 # during crash recovery.
 TimeoutSec=0
 
+# 0 is the same as infinity, but "infinity" needs systemd 229
+TimeoutStartSec=0
+
+TimeoutStopSec=1h
+
 [Install]

This is making assumptions about what order the values are applied
in, plus the initial comment is no longer very accurate.

			regards, tom lane

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: systemd service start - disable timeout with "infinity"
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox