pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedFirst WAL segment file that initdb creates
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2020-03-03 54a4f52a92 f22feedc25 53fc42c6d1 7a00f50ea6 e8b825bd76 d013c0bf9a Fix the name of the first WAL segment file, in docs.
* First WAL segment file that initdb creates
@ 2019-10-09 05:48 Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Fujii Masao @ 2019-10-09 05:48 UTC (permalink / raw)
To: pgsql-docs
Hi,
There is the following description in wal.sgml.
Segment
files are given ever-increasing numbers as names, starting at
<filename>000000010000000000000000</filename>.
But the first WAL segment file that initdb creates is 000000010000000000000001
not 000000010000000000000000. This change was caused by old commit 8c843fff2d,
but seems the documentation had not been updated unfortunately a long time.
Attached patch replaces 000000010000000000000000 with 000000010000000000000001
in the above description.
This patch needs to be back-patched to all the supported versions.
Regards,
--
Fujii Masao
Attachments:
first_wal_segment_v1.patch (application/octet-stream, 1007B) download
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index 4eb8feb903..bd9fae544c 100644
*** a/doc/src/sgml/wal.sgml
--- b/doc/src/sgml/wal.sgml
***************
*** 758,764 ****
are described in <filename>access/xlogrecord.h</filename>; the record
content is dependent on the type of event that is being logged. Segment
files are given ever-increasing numbers as names, starting at
! <filename>000000010000000000000000</filename>. The numbers do not wrap,
but it will take a very, very long time to exhaust the
available stock of numbers.
</para>
--- 758,764 ----
are described in <filename>access/xlogrecord.h</filename>; the record
content is dependent on the type of event that is being logged. Segment
files are given ever-increasing numbers as names, starting at
! <filename>000000010000000000000001</filename>. The numbers do not wrap,
but it will take a very, very long time to exhaust the
available stock of numbers.
</para>
* Re: First WAL segment file that initdb creates
@ 2020-02-18 20:26 David Zhang <david.zhang@highgo.ca>
parent: Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: David Zhang @ 2020-02-18 20:26 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org; +Cc: Fujii Masao <masao.fujii@gmail.com>
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed
The issue has been verified using below steps:
1. $ initdb -D /home/test/PG122DATA/data
2. $ ls -l /home/test/PG122DATA/data/pg_wal/
total 16388
-rw------- 1 test test 16777216 Feb 18 12:07 000000010000000000000001
drwx------ 2 test test 4096 Feb 18 12:07 archive_status
The first WAL segment file created by initdb is "000000010000000000000001", not "000000010000000000000000".
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: First WAL segment file that initdb creates
@ 2020-03-03 03:29 Fujii Masao <masao.fujii@oss.nttdata.com>
parent: David Zhang <david.zhang@highgo.ca>
0 siblings, 0 replies; 3+ messages in thread
From: Fujii Masao @ 2020-03-03 03:29 UTC (permalink / raw)
To: David Zhang <david.zhang@highgo.ca>; pgsql-hackers@lists.postgresql.org; +Cc: Fujii Masao <masao.fujii@gmail.com>
On 2020/02/19 5:26, David Zhang wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: not tested
> Spec compliant: not tested
> Documentation: tested, passed
>
> The issue has been verified using below steps:
> 1. $ initdb -D /home/test/PG122DATA/data
> 2. $ ls -l /home/test/PG122DATA/data/pg_wal/
> total 16388
> -rw------- 1 test test 16777216 Feb 18 12:07 000000010000000000000001
> drwx------ 2 test test 4096 Feb 18 12:07 archive_status
>
> The first WAL segment file created by initdb is "000000010000000000000001", not "000000010000000000000000".
Thanks for the test! I pushed the patch.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2020-03-03 03:29 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 05:48 First WAL segment file that initdb creates Fujii Masao <masao.fujii@gmail.com>
2020-02-18 20:26 ` David Zhang <david.zhang@highgo.ca>
2020-03-03 03:29 ` Fujii Masao <masao.fujii@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox