Re: Add minimal C example and SQL registration example for custom table access methods.

agora inbox for pgsql-docs@postgresql.org  
help / color / mirror / Atom feed

From: Roberto Mello <roberto.mello@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Add minimal C example and SQL registration example for custom table access methods.
Date: Wed, 15 Nov 2023 23:28:24 +0000
Message-ID: <170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CA+renyUC+sYP6Oj-bvwLF9H+b3eqAwGKUW3WP+Es4UBXkg04YQ@mail.gmail.com>
References: <CAByiw+r+CS-ojBDP7Dm=9YeOLkZTXVnBmOe_ajK=en8C_zB3_g@mail.gmail.com>
	<CA+renyUC+sYP6Oj-bvwLF9H+b3eqAwGKUW3WP+Es4UBXkg04YQ@mail.gmail.com>

Suggestion:

In the C example you added you mention in the comment:

+  /* Methods from TableAmRoutine omitted from example, but all
+     non-optional ones must be provided here. */

Perhaps you could provide a "see <xyz>" to point the reader finding your example where he could find these non-optional methods he must provide?

Nitpicking a little: your patch appears to change more lines than it does, because it added line breaks earlier in the lines. I would generally avoid that unless there's good reason to do so.

view thread (15+ messages)  latest in thread

Message-ID: <170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org>
Permalink:  ../170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org/
Also on:    postgresql.org/message-id/170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: roberto.mello@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add minimal C example and SQL registration example for custom table access methods.
  In-Reply-To: <170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox