pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedIncomplete sentence in the description for most_common_freqs
3+ messages / 3 participants
[nested] [flat]
* Incomplete sentence in the description for most_common_freqs
@ 2024-03-11 12:38 PG Doc comments form <noreply@postgresql.org>
2024-03-13 14:37 ` Re: Incomplete sentence in the description for most_common_freqs Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: PG Doc comments form @ 2024-03-11 12:38 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: ignacio.alonso@microsoft.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/view-pg-stats.html
Description:
https://www.postgresql.org/docs/current/view-pg-stats.html#VIEW-PG-STATS
It seems the ending clarifying sentence:
"(Null when most_common_vals is.)"
should rather be:
"(Null when most_common_vals is null.)"
Thanks,
Nacho
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Incomplete sentence in the description for most_common_freqs
2024-03-11 12:38 Incomplete sentence in the description for most_common_freqs PG Doc comments form <noreply@postgresql.org>
@ 2024-03-13 14:37 ` Tom Lane <tgl@sss.pgh.pa.us>
2024-03-13 15:19 ` Re: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs Nacho Alonso Portillo <Ignacio.Alonso@microsoft.com>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2024-03-13 14:37 UTC (permalink / raw)
To: ignacio.alonso@microsoft.com; +Cc: pgsql-docs@lists.postgresql.org
PG Doc comments form <noreply@postgresql.org> writes:
> It seems the ending clarifying sentence:
> "(Null when most_common_vals is.)"
> should rather be:
> "(Null when most_common_vals is null.)"
I think it's perfectly good English as-is, if a bit terse.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs
2024-03-11 12:38 Incomplete sentence in the description for most_common_freqs PG Doc comments form <noreply@postgresql.org>
2024-03-13 14:37 ` Re: Incomplete sentence in the description for most_common_freqs Tom Lane <tgl@sss.pgh.pa.us>
@ 2024-03-13 15:19 ` Nacho Alonso Portillo <Ignacio.Alonso@microsoft.com>
0 siblings, 0 replies; 3+ messages in thread
From: Nacho Alonso Portillo @ 2024-03-13 15:19 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Thanks Tom!
True it is that is perfectly valid English. However, that interpretation might not result trivial to us non-native English speakers.
Would be great if at some point it could be changed to make it clearer.
BTW, it also appears in the definition of the pg_stats_ext_exprs system view.
Regards,
Nacho
________________________________
From: Tom Lane <tgl@sss.pgh.pa.us>
Sent: Wednesday, March 13, 2024 3:37 PM
To: Nacho Alonso Portillo <Ignacio.Alonso@microsoft.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs
[You don't often get email from tgl@sss.pgh.pa.us. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
PG Doc comments form <noreply@postgresql.org> writes:
> It seems the ending clarifying sentence:
> "(Null when most_common_vals is.)"
> should rather be:
> "(Null when most_common_vals is null.)"
I think it's perfectly good English as-is, if a bit terse.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-03-13 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 12:38 Incomplete sentence in the description for most_common_freqs PG Doc comments form <noreply@postgresql.org>
2024-03-13 14:37 ` Tom Lane <tgl@sss.pgh.pa.us>
2024-03-13 15:19 ` Nacho Alonso Portillo <Ignacio.Alonso@microsoft.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox