From: Chao Li <li.evan.chao@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Fujii Masao <masao.fujii@gmail.com>
Subject: Re: Make pgoutput documentation easier to find
Date: Thu, 14 Aug 2025 04:04:40 +0000
Message-ID: <175514428026.994.9355658453872400400.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CAHGQGwG0zPyz0BqY5sR2y4OpTWQu9Sb2POH76wzG8_K-AJ72dQ@mail.gmail.com>
References: <CAHGQGwFJTbygdhhjR_iP4Oem=Lo1xsptWWOq825uoW+hG_Lfnw@mail.gmail.com>
<CAHGQGwG0zPyz0BqY5sR2y4OpTWQu9Sb2POH76wzG8_K-AJ72dQ@mail.gmail.com>
I applied the batch and built the html docs. I tested that all hyperlinks worked for me.
There are a few nit comments about wording:
diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgmlindex 593f784b69d..4516650983d 100644--- a/doc/src/sgml/logicaldecoding.sgml+++ b/doc/src/sgml/logicaldecoding.sgml
+ <xref linkend="test-decoding"/>. You can also write custom output plugins
nit: "write" -> "develop"
+ Protocol version. Currently versions <literal>1</literal>, <literal>2</literal>,
"Protocol version." -> "Specifies the protocol version."
+ Comma-separated list of publication names for which to subscribe
+ (receive changes). The individual publication names are treated
A comma-separated list of publication names to subscribe to. The individual publication names are treated
+ Boolean option to use binary transfer mode. Binary mode is faster
nit: "use" -> "enable", as other places all use "enable"
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgmlindex e56eac8fd0f..9fe48c5acad 100644--- a/doc/src/sgml/protocol.sgml+++ b/doc/src/sgml/protocol.sgml
+ The <literal>START_REPLICATION</literal> command allows us to
+ pass options to the logical decoding output plugin associated with
+ the replication slot specified in the command.
+ See <xref linkend="logicaldecoding-pgoutput-options"/> for options
+ that are accepted by the standard (<literal>pgoutput</literal>) plugin.
nit: The START_REPLICATION command can pass options to the logical decoding output plugin associated with the specified replication slot. See Section 47.6.1.1 for the options supported by the standard (pgoutput) plugin.
The new status of this patch is: Waiting on Author
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: li.evan.chao@gmail.com, pgsql-hackers@lists.postgresql.org, masao.fujii@gmail.com
Subject: Re: Make pgoutput documentation easier to find
In-Reply-To: <175514428026.994.9355658453872400400.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox