pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-documentation <pgsql-docs@postgresql.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Moving tablespaces
Date: Tue, 06 Dec 2011 10:12:32 -0500
Message-ID: <19894.1323184352@sss.pgh.pa.us> (raw)
In-Reply-To: <CABUevEyP-20VSpgBP9J16=vk9-fxj8O6KPr63r9jQxHoca9JeA@mail.gmail.com>
References: <CABUevEx2xYV==WRxWdMr=mS3Q1orBUvJcXa8AZx_LVbL122g5Q@mail.gmail.com>
	<201112041612.pB4GCHt06225@momjian.us>
	<CABUevEzuRQLddyY2yypiZpjWzzEzz0p66TgzoXGuz+jLxKgdkg@mail.gmail.com>
	<23636.1323016890@sss.pgh.pa.us>
	<4EDBA60D.2050904@dunslane.net>
	<26148.1323018451@sss.pgh.pa.us>
	<CABUevEyP-20VSpgBP9J16=vk9-fxj8O6KPr63r9jQxHoca9JeA@mail.gmail.com>

Magnus Hagander <magnus@hagander.net> writes:
> AFAICT, it should be as simple as the attached.

Oh, one other thought is that the function body has to be
conditionalized on HAVE_READLINK (the fact that you forgot that
somewhere else isn't an excuse for not doing it here).  IIRC,
only the two built-in tablespaces can exist when not HAVE_READLINK,
so it seems sufficient to handle those cases and then PG_RETURN_NULL
(or maybe throw error) when not HAVE_READLINK.

			regards, tom lane

view thread (17+ messages)  latest in thread

Message-ID: <19894.1323184352@sss.pgh.pa.us>
Permalink:  ../19894.1323184352@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19894.1323184352@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, magnus@hagander.net, andrew@dunslane.net, bruce@momjian.us, pgsql-hackers@postgresql.org
  Subject: Re: [HACKERS] Moving tablespaces
  In-Reply-To: <19894.1323184352@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox