public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: Tom Lane <[email protected]>
Cc: Russell Smith <[email protected]>
Cc: David Fetter <[email protected]>
Cc: PostgreSQL Docs <[email protected]>
Cc: PostgreSQL Patches <[email protected]>
Subject: Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries
Date: Fri, 6 Apr 2007 23:49:04 -0400 (EDT)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Tom Lane wrote:
> Russell Smith <[email protected]> writes:
> > Tom Lane wrote:
> >> The entire *point* of that paragraph is that we don't have the
> >> feature.  This proposed change is surely not an improvement...
> >> 
> > Maybe removing the entire example would be more helpful.  I don't find 
> > it clear to have a command outline in a compatibility block.
> 
> True, there doesn't seem to be any point in providing a full syntax
> summary rather than just saying "the SQL spec says you can grant
> privileges on columns but we don't support that yet".

Agreed.  Patch attached and applied.  I don't see any other cases of
this in our documentation.

-- 
  Bruce Momjian  <[email protected]>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +


Attachments:

  [text/x-diff] /rtmp/diff (2.5K, 2-%2Frtmp%2Fdiff)
  download | inline diff:
Index: doc/src/sgml/ref/grant.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/grant.sgml,v
retrieving revision 1.64
diff -c -c -r1.64 grant.sgml
*** doc/src/sgml/ref/grant.sgml	1 Feb 2007 00:28:19 -0000	1.64
--- doc/src/sgml/ref/grant.sgml	7 Apr 2007 03:45:36 -0000
***************
*** 520,533 ****
     </para>
  
     <para>
!     The SQL standard allows setting privileges for individual columns
!     within a table:
! 
! <synopsis>
! GRANT <replaceable class="PARAMETER">privileges</replaceable>
!     ON <replaceable class="PARAMETER">table</replaceable> [ ( <replaceable class="PARAMETER">column</replaceable> [, ...] ) ] [, ...]
!     TO { PUBLIC | <replaceable class="PARAMETER">username</replaceable> [, ...] } [ WITH GRANT OPTION ]
! </synopsis>
     </para>
  
     <para>
--- 520,527 ----
     </para>
  
     <para>
!     <productname>PostgreSQL</productname> does not support the SQL-standard 
!     functionality of setting privileges for individual columns.
     </para>
  
     <para>
Index: doc/src/sgml/ref/revoke.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/revoke.sgml,v
retrieving revision 1.42
diff -c -c -r1.42 revoke.sgml
*** doc/src/sgml/ref/revoke.sgml	31 Jan 2007 23:26:04 -0000	1.42
--- doc/src/sgml/ref/revoke.sgml	7 Apr 2007 03:45:37 -0000
***************
*** 231,245 ****
  
     <para>
      The compatibility notes of the <xref linkend="sql-grant" endterm="sql-grant-title"> command
!     apply analogously to <command>REVOKE</command>.  The syntax summary is:
! 
! <synopsis>
! REVOKE [ GRANT OPTION FOR ] <replaceable class="PARAMETER">privileges</replaceable>
!     ON <replaceable class="parameter">object</replaceable> [ ( <replaceable class="parameter">column</replaceable> [, ...] ) ]
!     FROM { PUBLIC | <replaceable class="parameter">username</replaceable> [, ...] }
!     { RESTRICT | CASCADE }
! </synopsis>
!     One of <literal>RESTRICT</literal> or <literal>CASCADE</literal>
      is required according to the standard, but <productname>PostgreSQL</>
      assumes <literal>RESTRICT</literal> by default.
     </para>
--- 231,238 ----
  
     <para>
      The compatibility notes of the <xref linkend="sql-grant" endterm="sql-grant-title"> command
!     apply analogously to <command>REVOKE</command>.
!     <literal>RESTRICT</literal> or <literal>CASCADE</literal>
      is required according to the standard, but <productname>PostgreSQL</>
      assumes <literal>RESTRICT</literal> by default.
     </para>


view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox