public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Chris Browne <[email protected]>
Cc: [email protected]
Subject: Re: [DOCS] Autovacuum and XID wraparound
Date: Wed, 16 May 2007 12:38:04 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<1179117269.6047.3.camel@goldbach>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Heikki Linnakangas wrote:
> Alvaro Herrera wrote:
> >However, given that Heikki just confirmed that CLUSTER does not freeze
> >tuples, it's not really possible to do this, so I'll drop the CLUSTER
> >patch for now.
> >
> >This means that people using CLUSTER to compact tables won't have the
> >benefit of advancing relfrozenxid, so they will have to run VACUUM on
> >those tables at some point anyway, even though there will be no dead
> >tuples :-(
> 
> Now that I think this a bit more, I think CLUSTER should freeze the 
> tuples. I was worried about losing valuable debug information by doing 
> that, but thinking a bit more that's not a big concern: we wouldn't 
> freeze tuples newer than recent xmin. The update chain logic is the most 
> risky part of the code, and we wouldn't lose the xmin and xmax of tuples 
> that are part of update chains.
> 
> Patch attached. You'll need the changes to cluster.c to set the 
> relfrozenid as well.

Thanks, committed.  (I changed NULL for InvalidBuffer).

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

view thread (34+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [DOCS] Autovacuum and XID wraparound
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox