public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Tom Lane <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Chris Browne <[email protected]>
Cc: [email protected]
Subject: Re: [DOCS] Autovacuum and XID wraparound
Date: Thu, 17 May 2007 11:53:19 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Tom Lane wrote:
> Alvaro Herrera <[email protected]> writes:
> > Here is my proposed patch.
> 
> Actually, the original patch in this series was fairly horrid, and
> things haven't been made better by the subsequent changes.  It lacked
> any comment explaining what it was doing; failed to comment on the way
> it was abusing heap_freeze_tuple (the latter thinks it's getting a tuple
> that's in a disk buffer); and IMHO puts the heap_freeze_tuple call in
> the wrong place anyway.  raw_heap_insert has no business editorializing
> on the tuple it's given.  It'd be better to have the call in
> rewrite_heap_tuple, which is already busy messing with the tuple's
> visibility info.  Perhaps like this, in addition to your changes:

Applied, thanks.  Let me know if there is still something you don't like
about the current state of cluster or truncate.

The part about actually advancing relfrozenxid is still not done though ...

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

view thread (34+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [DOCS] Autovacuum and XID wraparound
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox