public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: Euler Taveira de Oliveira <[email protected]>
Cc: PostgreSQL-documentation <[email protected]>
Subject: Re: log_min_duration_statement units
Date: Tue, 7 Apr 2009 18:32:09 -0400 (EDT)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Euler Taveira de Oliveira wrote:
> > > Bruce Momjian escreveu:
> > > > Oops, here is the patch;  Euler, would you look to see if you can find
> > > > anything else missing;  you seem to be good at that.  :-)
> > > > 
> > > My English is not as good as yours but here is another try. Personally, I 
> > > prefer the second one but...
> > 
> > Great, I used your second version.  I had already done some of the ones
> > you found, but you had many more.  I also used your "0 disables" wording
> > consistently in the file.  Thanks for the help.  Committed.
> 
> Huh ... I thought the units were removed from the descriptions when the
> whole unit thing got introduced in guc.c.  This seems more a regression
> than anything else -- see guc.c rev 1.361.

Which is why I originally did:

	#log_min_duration_statement = -1ms        # -1 is disabled, 0 logs all statements

but people complained so I went with adding it to the description.  The
units are only to document the default if no units are supplied.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: log_min_duration_statement units
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox