public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: Tom Lane <[email protected]>
Cc: Euler Taveira de Oliveira <[email protected]>
Cc: PostgreSQL-documentation <[email protected]>
Subject: Re: log_min_duration_statement units
Date: Tue, 7 Apr 2009 19:27:56 -0400 (EDT)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Tom Lane wrote:
> Bruce Momjian <[email protected]> writes:
> > Tom Lane wrote:
> >> You know, it suddenly strikes me that this is going in largely the wrong
> >> direction.
>
> > Right, the problem particularly is with the -1/special values that don't
> > have a real unit.
>
> I don't object to what you did to postgresql.conf.sample, but I think
> you should revert the changes to the descriptions in guc.c.
Agreed; attached patch applied.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachments:
[text/x-diff] /rtmp/diff (6.6K, 2-%2Frtmp%2Fdiff)
download | inline diff:
Index: guc.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.499
retrieving revision 1.501
diff -c -c -r1.499 -r1.501
*** guc.c 2 Apr 2009 19:57:19 -0000 1.499
--- guc.c 7 Apr 2009 22:22:19 -0000 1.501
***************
*** 10,16 ****
* Written by Peter Eisentraut <[email protected]>.
*
* IDENTIFICATION
! * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.499 2009/04/02 19:57:19 momjian Exp $
*
*--------------------------------------------------------------------
*/
--- 10,16 ----
* Written by Peter Eisentraut <[email protected]>.
*
* IDENTIFICATION
! * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.501 2009/04/07 22:22:19 momjian Exp $
*
*--------------------------------------------------------------------
*/
***************
*** 1316,1322 ****
{
/* This is PGC_SIGHUP so all backends have the same value. */
{"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT,
! gettext_noop("Sets the time to wait on a lock before checking for deadlock."),
NULL,
GUC_UNIT_MS
},
--- 1316,1322 ----
{
/* This is PGC_SIGHUP so all backends have the same value. */
{"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT,
! gettext_noop("Sets the time to wait on a lock before checking for deadlock, in milliseconds."),
NULL,
GUC_UNIT_MS
},
***************
*** 1406,1412 ****
{
{"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM,
! gettext_noop("Sets the maximum memory to be used for maintenance operations."),
gettext_noop("This includes operations such as VACUUM and CREATE INDEX."),
GUC_UNIT_KB
},
--- 1406,1412 ----
{
{"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM,
! gettext_noop("Sets the maximum memory to be used for maintenance operations, in kilobytes."),
gettext_noop("This includes operations such as VACUUM and CREATE INDEX."),
GUC_UNIT_KB
},
***************
*** 1530,1536 ****
{
{"statement_timeout", PGC_USERSET, CLIENT_CONN_STATEMENT,
! gettext_noop("Sets the maximum allowed duration of any statement."),
gettext_noop("A value of 0 turns off the timeout."),
GUC_UNIT_MS
},
--- 1530,1536 ----
{
{"statement_timeout", PGC_USERSET, CLIENT_CONN_STATEMENT,
! gettext_noop("Sets the maximum duration of any statement, in milliseconds."),
gettext_noop("A value of 0 turns off the timeout."),
GUC_UNIT_MS
},
***************
*** 1569,1575 ****
{
{"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY,
! gettext_noop("Sets the maximum allowed time to complete client authentication."),
NULL,
GUC_UNIT_S
},
--- 1569,1575 ----
{
{"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY,
! gettext_noop("Sets the maximum allowed time to complete client authentication, in seconds."),
NULL,
GUC_UNIT_S
},
***************
*** 1599,1605 ****
{
{"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS,
! gettext_noop("Sets the maximum time between automatic WAL checkpoints."),
NULL,
GUC_UNIT_S
},
--- 1599,1605 ----
{
{"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS,
! gettext_noop("Sets the maximum time between automatic WAL checkpoints, in seconds."),
NULL,
GUC_UNIT_S
},
***************
*** 1632,1638 ****
{
{"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS,
! gettext_noop("WAL writer sleep time between WAL flushes."),
NULL,
GUC_UNIT_MS
},
--- 1632,1638 ----
{
{"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS,
! gettext_noop("WAL writer sleep time between WAL flushes, in milliseconds."),
NULL,
GUC_UNIT_MS
},
***************
*** 1673,1680 ****
{
{"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN,
! gettext_noop("Sets the minimum execution time above which "
! "statements will be logged."),
gettext_noop("Zero prints all queries. -1 turns this feature off."),
GUC_UNIT_MS
},
--- 1673,1680 ----
{
{"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN,
! gettext_noop("Sets the minimum execution time (in milliseconds) above "
! "which statements will be logged."),
gettext_noop("Zero prints all queries. -1 turns this feature off."),
GUC_UNIT_MS
},
***************
*** 1684,1690 ****
{
{"log_autovacuum_min_duration", PGC_SIGHUP, LOGGING_WHAT,
! gettext_noop("Sets the minimum execution time above which "
"autovacuum actions will be logged."),
gettext_noop("Zero prints all actions. -1 turns autovacuum logging off."),
GUC_UNIT_MS
--- 1684,1690 ----
{
{"log_autovacuum_min_duration", PGC_SIGHUP, LOGGING_WHAT,
! gettext_noop("Sets the minimum execution in milliseconds above which "
"autovacuum actions will be logged."),
gettext_noop("Zero prints all actions. -1 turns autovacuum logging off."),
GUC_UNIT_MS
***************
*** 1695,1701 ****
{
{"bgwriter_delay", PGC_SIGHUP, RESOURCES,
! gettext_noop("Background writer sleep time between rounds."),
NULL,
GUC_UNIT_MS
},
--- 1695,1701 ----
{
{"bgwriter_delay", PGC_SIGHUP, RESOURCES,
! gettext_noop("Background writer sleep time between rounds, in milliseconds."),
NULL,
GUC_UNIT_MS
},
***************
*** 1827,1833 ****
{
{"autovacuum_naptime", PGC_SIGHUP, AUTOVACUUM,
! gettext_noop("Time to sleep between autovacuum runs."),
NULL,
GUC_UNIT_S
},
--- 1827,1833 ----
{
{"autovacuum_naptime", PGC_SIGHUP, AUTOVACUUM,
! gettext_noop("Time to sleep between autovacuum runs, in seconds."),
NULL,
GUC_UNIT_S
},
***************
*** 1871,1877 ****
{
{"tcp_keepalives_idle", PGC_USERSET, CLIENT_CONN_OTHER,
! gettext_noop("Time between issuing TCP keepalives."),
gettext_noop("A value of 0 uses the system default."),
GUC_UNIT_S
},
--- 1871,1877 ----
{
{"tcp_keepalives_idle", PGC_USERSET, CLIENT_CONN_OTHER,
! gettext_noop("Seconds between issuing TCP keepalives."),
gettext_noop("A value of 0 uses the system default."),
GUC_UNIT_S
},
***************
*** 1881,1887 ****
{
{"tcp_keepalives_interval", PGC_USERSET, CLIENT_CONN_OTHER,
! gettext_noop("Time between TCP keepalive retransmits."),
gettext_noop("A value of 0 uses the system default."),
GUC_UNIT_S
},
--- 1881,1887 ----
{
{"tcp_keepalives_interval", PGC_USERSET, CLIENT_CONN_OTHER,
! gettext_noop("Seconds between TCP keepalive retransmits."),
gettext_noop("A value of 0 uses the system default."),
GUC_UNIT_S
},
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: log_min_duration_statement units
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox