public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: Josh Berkus <[email protected]>
Cc: [email protected]
Subject: Re: libpq-example.html needs to use <> includes
Date: Fri, 26 Feb 2010 22:41:36 -0500 (EST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Josh Berkus wrote:
> All,
>
> The libpq-example is using local includes for libpq-fe, instead of
> library includes:
>
> #include "libpq-fe.h"
>
> I can't think of a single good reason for this, is there one?
Agreed, fixed with the attached, applied patch.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +
Attachments:
[text/x-diff] /rtmp/diff (1.3K, 2-%2Frtmp%2Fdiff)
download | inline diff:
Index: doc/src/sgml/libpq.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/libpq.sgml,v
retrieving revision 1.302
diff -c -c -r1.302 libpq.sgml
*** doc/src/sgml/libpq.sgml 24 Feb 2010 15:54:31 -0000 1.302
--- doc/src/sgml/libpq.sgml 27 Feb 2010 03:40:36 -0000
***************
*** 7010,7016 ****
*/
#include <stdio.h>
#include <stdlib.h>
! #include "libpq-fe.h"
static void
exit_nicely(PGconn *conn)
--- 7010,7016 ----
*/
#include <stdio.h>
#include <stdlib.h>
! #include <libpq-fe.h>
static void
exit_nicely(PGconn *conn)
***************
*** 7158,7164 ****
#include <string.h>
#include <errno.h>
#include <sys/time.h>
! #include "libpq-fe.h"
static void
exit_nicely(PGconn *conn)
--- 7158,7164 ----
#include <string.h>
#include <errno.h>
#include <sys/time.h>
! #include <libpq-fe.h>
static void
exit_nicely(PGconn *conn)
***************
*** 7296,7302 ****
#include <stdlib.h>
#include <string.h>
#include <sys/types.h>
! #include "libpq-fe.h"
/* for ntohl/htonl */
#include <netinet/in.h>
--- 7296,7302 ----
#include <stdlib.h>
#include <string.h>
#include <sys/types.h>
! #include <libpq-fe.h>
/* for ntohl/htonl */
#include <netinet/in.h>
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: libpq-example.html needs to use <> includes
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox