public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Tom Lane <[email protected]>
Cc: Josh Kupershmidt <[email protected]>
Cc: [email protected]
Subject: Re: confusing archive_command example
Date: Wed, 31 Mar 2010 20:31:32 -0400 (EDT)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Tom Lane wrote:
> Bruce Momjian <[email protected]> writes:
> > His complaint was that .../%f looks like ../%f;  is that a valid
> > concern?
> 
> Well, it does look like it, I'm just not seeing an easy fix that makes
> that better.  I think the original suggestion was to turn it into a
> concrete example by writing something like /mnt/archive/%f.
> 
> > I have reverted the change.  Also, should we be using test !
> > -e instead of -f?
> 
> No opinion.

Well -e tests for any type of file, while -f is only for regular files. 
In practice, there should only be regular files in the archive
directory.  But because we are always super-cautious, I changed it to
-e.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: confusing archive_command example
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox