public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: Ray Stell <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected]
Subject: Re: create foreign table
Date: Wed, 15 Aug 2012 20:38:36 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Thu, Sep 15, 2011 at 12:51:57PM -0400, Ray Stell wrote:
> On Thu, Sep 15, 2011 at 06:43:59AM -0500, Robert Haas wrote:
> >> On Mon, Sep 12, 2011 at 8:42 AM, Ray Stell <[email protected]> wrote:
> >> > http://www.postgresql.org/docs/9.1/static/sql-createforeigntable.html
> >> > It would be helpful if "SERVER" was defined if the parameters list
> >> > on this page.
> >>
> >> We don't usually document required keywords - they're just required.
> >> We do document the meaning of server_name, which I think is probably
> >> what you were after.
> >>
> >> --
> >> Robert Haas
> >> EnterpriseDB: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
> >Thanks, Robert.
> >
> >Maybe if you just added a pointer to the "CREATE SERVER" command in
> >your definition of server_name it would provide a bread crumb.
> >
> 
> Oh, I see my mistake.  Maybe the inclusion of a link to "CREATE SERVER"
> http://www.postgresql.org/docs/9.1/static/sql-createserver.html in the
> server_name definition would be helpful, just like in the data_type line.
> I was having trouble making the leap since the idea was a new one on me.

I have done as you suggested with the attached patch which will appear
in Postgres 9.3.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +


Attachments:

  [text/x-diff] server.diff (708B, 2-server.diff)
  download | inline diff:
diff --git a/doc/src/sgml/ref/create_foreign_table.sgml b/doc/src/sgml/ref/create_foreign_table.sgml
new file mode 100644
index 2113d00..f860ad0
*** a/doc/src/sgml/ref/create_foreign_table.sgml
--- b/doc/src/sgml/ref/create_foreign_table.sgml
*************** CREATE FOREIGN TABLE [ IF NOT EXISTS ] <
*** 135,141 ****
      <listitem>
       <para>
        The name of an existing server for the foreign table.
!      </para>
      </listitem>
     </varlistentry>
  
--- 135,142 ----
      <listitem>
       <para>
        The name of an existing server for the foreign table.
!       For details on defining a server, see <xref
!       linkend="SQL-CREATESERVER">.
      </listitem>
     </varlistentry>
  


view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: create foreign table
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox