public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: Josh Kupershmidt <[email protected]>
Cc: Greg Smith <[email protected]>
Cc: Euler Taveira de Oliveira <[email protected]>
Cc: [email protected]
Subject: Re: somewhat wrong archive_command example
Date: Wed, 15 Aug 2012 21:13:47 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAK3UJRHChOcGQ0kzu01wZX6PB9pScHSzg1X+hThdR7QXWoe1yw@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAK3UJRHChOcGQ0kzu01wZX6PB9pScHSzg1X+hThdR7QXWoe1yw@mail.gmail.com>
On Thu, Sep 22, 2011 at 02:15:30PM -0400, Josh Kupershmidt wrote:
> On Wed, Sep 21, 2011 at 8:59 PM, Euler Taveira de Oliveira
> <[email protected]> wrote:
> > On 21-09-2011 20:02, Greg Smith wrote:
> >>
> >> Attached version fixes the late night brain fade errors. I think the right
> >> thing to do next is to package this up into a doc update that corrects the
> >> errors in that section too; just clean the whole thing up while I'm poking
> >> at
> >> it. I'll submit that over to the hackers list so that everyone can take a
> >> shot
> >> at correcting my shell code.
>
> First, a +1 on the impetus for this script.
>
> Few more suggestions/nitpicks:
> 1.) IMO it's more logical to put the test for whether the $ARCHIVE
> directory exists before the test whether ${ARCHIVE}/${FILE} exists.
> 2.) I think the error code reporting here is not sound:
>
> cp ${FULLPATH} ${ARCHIVE}/${FILE}
> if [ $? -ne 0 ] ; then
> echo $0 Archive copy of ${FILE} failed with error $? >&2
>
> at least on my OS X machine, that echo produces a message like
> "./local_backup_script.sh Archive copy of failed with error 0", I
> guess since $? gets reset to 0 after that if-statement. You can use a
> temporary variable like $ERRCODE=$? to get around this.
I have made all the suggestions posted and would like to add the
attached script to our documentation as a simple example.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachments:
[application/x-sh] local_backup_script.sh (531B, 2-local_backup_script.sh)
download
view thread (24+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: somewhat wrong archive_command example
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox