public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: Dmitriy Igrishin <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: Clarification suggestion for 46.4 chapter.
Date: Thu, 16 Aug 2012 22:07:35 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAfz9KN4PEf0QodA_F37M6RifK2sMXR8bjAgUqGuNKqOdVchXw@mail.gmail.com>
References: <CAAfz9KN4PEf0QodA_F37M6RifK2sMXR8bjAgUqGuNKqOdVchXw@mail.gmail.com>

On Mon, Dec  5, 2011 at 02:53:22PM +0300, Dmitriy Igrishin wrote:
> Hey,
> 
> The section 46.4 describes the base data types used in messages.
> http://www.postgresql.org/docs/9.1/static/protocol-message-types.html
> 
> According to section 46.5
> http://www.postgresql.org/docs/9.1/static/protocol-message-formats.html
> there are cases when Int32 can be negative (e.g. see DataRow(B) message
> description.)
> 
> Thus, I would like to suggest to change the description of Int(i)
> from
> "An n-bit integer in network byte order ..."
> to
> "An n-bit signed integer in network byte order ..."

OK, documentation updated.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +


Attachments:

  [text/x-diff] int.diff (893B, 2-int.diff)
  download | inline diff:
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
new file mode 100644
index e725563..8778c58
*** a/doc/src/sgml/protocol.sgml
--- b/doc/src/sgml/protocol.sgml
*************** This section describes the base data typ
*** 1819,1825 ****
  </term>
  <listitem>
  <para>
!                 An <replaceable>n</replaceable>-bit integer in network byte
                  order (most significant byte first).
                  If <replaceable>i</replaceable> is specified it
                  is the exact value that will appear, otherwise the value
--- 1819,1825 ----
  </term>
  <listitem>
  <para>
!                 An <replaceable>n</replaceable>-bit signed integer in network byte
                  order (most significant byte first).
                  If <replaceable>i</replaceable> is specified it
                  is the exact value that will appear, otherwise the value


view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Clarification suggestion for 46.4 chapter.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox