public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: Josh Kupershmidt <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: pgtesttiming.sgml, FreeBSD command output
Date: Thu, 30 Aug 2012 18:38:21 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAK3UJRFe51f_4Sc0a-QK6uTsXLMHtyV7cmKQJX13gAbs0qVGCw@mail.gmail.com>
References: <CAK3UJRHJvGJZW80S3=5HJ0TMG5QmkXH5YaTS2K_0-9kQKP-a5g@mail.gmail.com>
<[email protected]>
<CAK3UJRFe51f_4Sc0a-QK6uTsXLMHtyV7cmKQJX13gAbs0qVGCw@mail.gmail.com>
Patch attached and applied for PG 9.3.
---------------------------------------------------------------------------
On Fri, Jul 6, 2012 at 02:09:00PM -0700, Josh Kupershmidt wrote:
> On Fri, Jul 6, 2012 at 1:33 PM, Peter Eisentraut <[email protected]> wrote:
> > On fre, 2012-07-06 at 13:21 -0700, Josh Kupershmidt wrote:
>
> >> <screen>
> >> dmesg | grep "Timecounter"
> >> sysctl kern.timecounter.hardware=TSC
> >> </screen>
> >>
> >> First, grep is case-sensitive by default, so that line of output
> >> shouldn't have matched at all, right?
> >
> > I don't think this was meant to say that the second line is the output
> > of the first. I read this as two separate commands. But I agree this
> > part is a bit unclear.
>
> Oh, I see now. The <screen> sections above and below that one were
> including output, and I was just expecting the same here.
>
> One way to fix would be to include shell prompts and outputs for both
> commands (patch Option 1, attached). Or, if we don't want to bother
> including output, as the section does now, maybe we could at least
> include the shell prompts and mention that output is excluded (patch
> Option 2).
>
> I've also attached an unrelated typofix I noticed for the same page.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachments:
[text/x-diff] timer.diff (1.5K, 2-timer.diff)
download | inline diff:
diff --git a/doc/src/sgml/pgtesttiming.sgml b/doc/src/sgml/pgtesttiming.sgml
new file mode 100644
index 45ee80c..a2581d2
*** a/doc/src/sgml/pgtesttiming.sgml
--- b/doc/src/sgml/pgtesttiming.sgml
*************** Histogram of timing durations:
*** 183,190 ****
information about the timer selected during boot:
<screen>
! dmesg | grep "Timecounter"
! sysctl kern.timecounter.hardware=TSC
</screen>
</para>
--- 183,195 ----
information about the timer selected during boot:
<screen>
! # dmesg | grep "Timecounter"
! Timecounter "ACPI-fast" frequency 3579545 Hz quality 900
! Timecounter "i8254" frequency 1193182 Hz quality 0
! Timecounters tick every 10.000 msec
! Timecounter "TSC" frequency 2531787134 Hz quality 800
! # sysctl kern.timecounter.hardware=TSC
! kern.timecounter.hardware: ACPI-fast -> TSC
</screen>
</para>
*************** Histogram of timing durations:
*** 277,283 ****
</para>
<para>
! Timers used on older PC hardware including the 8254 Programmable Interval
Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
Controller (APIC) timer, and the Cyclone timer. These timers aim for
millisecond resolution.
--- 282,288 ----
</para>
<para>
! Timers used on older PC hardware include the 8254 Programmable Interval
Timer (PIT), the real-time clock (RTC), the Advanced Programmable Interrupt
Controller (APIC) timer, and the Cyclone timer. These timers aim for
millisecond resolution.
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgtesttiming.sgml, FreeBSD command output
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox