From: Bruce Momjian <bruce@momjian.us>
To: Jason O'Donnell <odonnelljp01@gmail.com>
Cc: pgsql-docs@postgresql.org
Subject: Re: Example error in createdb doc
Date: Tue, 22 Nov 2016 17:31:44 -0500
Message-ID: <20161122223144.GA31341@momjian.us> (raw)
In-Reply-To: <CAOYeSOdUxLryVKsNkKs3tXCGSdQi2H7Wr6kMCWLpPnhu-JO_qQ@mail.gmail.com>
References: <CAOYeSOdUxLryVKsNkKs3tXCGSdQi2H7Wr6kMCWLpPnhu-JO_qQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
On Thu, Oct 27, 2016 at 09:01:59PM -0400, Jason O'Donnell wrote:
> Hello,
>
> I believe I've found an incorrect example in the createdb documentation:
> https://www.postgresql.org/docs/current/static/app-createdb.html
>
> The example given for createdb fails because template0 is not provided:
>
> [~] createdb -p 5000 -h eden -E LATIN1 -e demo
> CREATE DATABASE demo ENCODING 'LATIN1';
> createdb: database creation failed: ERROR: new encoding (LATIN1) is
> incompatible with the encoding of the template database (SQL_ASCII)
> HINT: Use the same encoding as in the template database, or use template0 as
> template.
>
> I've attached a patch that addresses the issue.
...
> diff --git a/doc/src/sgml/ref/createdb.sgml b/doc/src/sgml/ref/createdb.sgml
> index c363bd4..bd1de1f2f 100644
> --- a/doc/src/sgml/ref/createdb.sgml
> +++ b/doc/src/sgml/ref/createdb.sgml
> @@ -366,8 +366,8 @@ PostgreSQL documentation
> <literal>LATIN1</literal> encoding scheme with a look at the
> underlying command:
> <screen>
> -<prompt>$ </prompt><userinput>createdb -p 5000 -h eden -E LATIN1 -e demo</userinput>
> -<computeroutput>CREATE DATABASE demo ENCODING 'LATIN1';</computeroutput>
> +<prompt>$ </prompt><userinput>createdb -p 5000 -h eden -E LATIN1 -T template0 -e demo</userinput>
> +<computeroutput>CREATE DATABASE demo ENCODING 'LATIN1' TEMPLATE template0;</computeroutput>
> </screen></para>
> </refsect1>
I have looked over this report and patch, and it just doesn't feel
right. The example is intending to show how to use common psql-like
options to control createdb. Adding the encoding is nice, but then
having to switch to template0 so the encoding setting works just seems
beyond the scope of what we want do there.
I think the attached patch is more focused.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docsAttachments:createdb.diff (text/x-diff, 1.1K) downloaddiff --git a/doc/src/sgml/ref/createdb.sgml b/doc/src/sgml/ref/createdb.sgmlnew file mode 100644index c363bd4..0cad708
*** a/doc/src/sgml/ref/createdb.sgml
--- b/doc/src/sgml/ref/createdb.sgml
*************** PostgreSQL documentation
*** 362,373 ****
<para>
To create the database <literal>demo</literal> using the
! server on host <literal>eden</>, port 5000, using the
! <literal>LATIN1</literal> encoding scheme with a look at the
! underlying command:
<screen>
! <prompt>$ </prompt><userinput>createdb -p 5000 -h eden -E LATIN1 -e demo</userinput>
! <computeroutput>CREATE DATABASE demo ENCODING 'LATIN1';</computeroutput>
</screen></para>
</refsect1>
--- 362,372 ----
<para>
To create the database <literal>demo</literal> using the
! server on host <literal>eden</>, port 5000, here is the command-line
! command and the underlying SQL command:
<screen>
! <prompt>$ </prompt><userinput>createdb -p 5000 -h eden -e demo</userinput>
! <computeroutput>CREATE DATABASE demo;</computeroutput>
</screen></para>
</refsect1>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, odonnelljp01@gmail.com
Subject: Re: Example error in createdb doc
In-Reply-To: <20161122223144.GA31341@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox