pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedChange wording for PG_MODULE_MAGIC inclusion
7+ messages / 4 participants
[nested] [flat]
* Change wording for PG_MODULE_MAGIC inclusion
@ 2017-08-30 12:33 Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Gustafsson @ 2017-08-30 12:33 UTC (permalink / raw)
To: pgsql-docs
With 8.1 being fairly far down on the EOL list, it seems about time to update
the docs regarding PG_MODULE_MAGIC to mention the pre-8.2 #ifdef guards as an
exception and not the default. Not sure if a Note should be used, or just a
paragraph, so opted for a paragraph.
This also removes the last two occurrences in the code.
cheers ./daniel
Attachments:
pg_module_magic.patch (application/octet-stream, 0B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Change wording for PG_MODULE_MAGIC inclusion
@ 2017-08-30 14:35 Alvaro Herrera <alvherre@2ndquadrant.com>
parent: Daniel Gustafsson <daniel@yesql.se>
0 siblings, 2 replies; 7+ messages in thread
From: Alvaro Herrera @ 2017-08-30 14:35 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: pgsql-docs
Daniel Gustafsson wrote:
> With 8.1 being fairly far down on the EOL list, it seems about time to update
> the docs regarding PG_MODULE_MAGIC to mention the pre-8.2 #ifdef guards as an
> exception and not the default. Not sure if a Note should be used, or just a
> paragraph, so opted for a paragraph.
Uh, why would anybody be reading the pg10 docs in order to compile
modules for 8.2? I vote to just drop the suggestion that there needs to
be an #ifdef guard altogether.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Change wording for PG_MODULE_MAGIC inclusion
@ 2017-08-30 14:51 Tom Lane <tgl@sss.pgh.pa.us>
parent: Alvaro Herrera <alvherre@2ndquadrant.com>
1 sibling, 1 reply; 7+ messages in thread
From: Tom Lane @ 2017-08-30 14:51 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: Daniel Gustafsson <daniel@yesql.se>; pgsql-docs
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Uh, why would anybody be reading the pg10 docs in order to compile
> modules for 8.2? I vote to just drop the suggestion that there needs to
> be an #ifdef guard altogether.
+1 ... if you are reading the current docs, they're going to tell you
lots of things that won't work in 8.1.
regards, tom lane
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Change wording for PG_MODULE_MAGIC inclusion
@ 2017-08-30 14:52 Daniel Gustafsson <daniel@yesql.se>
parent: Alvaro Herrera <alvherre@2ndquadrant.com>
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2017-08-30 14:52 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: pgsql-docs
> On 30 Aug 2017, at 16:35, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> Daniel Gustafsson wrote:
>> With 8.1 being fairly far down on the EOL list, it seems about time to update
>> the docs regarding PG_MODULE_MAGIC to mention the pre-8.2 #ifdef guards as an
>> exception and not the default. Not sure if a Note should be used, or just a
>> paragraph, so opted for a paragraph.
>
> Uh, why would anybody be reading the pg10 docs in order to compile
> modules for 8.2? I vote to just drop the suggestion that there needs to
> be an #ifdef guard altogether.
I would not object to that, I was being a bit too careful I think.
cheers ./daniel
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Change wording for PG_MODULE_MAGIC inclusion
@ 2017-08-30 17:28 Daniel Gustafsson <daniel@yesql.se>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Gustafsson @ 2017-08-30 17:28 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-docs
> On 30 Aug 2017, at 16:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> Uh, why would anybody be reading the pg10 docs in order to compile
>> modules for 8.2? I vote to just drop the suggestion that there needs to
>> be an #ifdef guard altogether.
>
> +1 ... if you are reading the current docs, they're going to tell you
> lots of things that won't work in 8.1.
Patch updated with dropping the #ifdef guard paragraph. Also removed the
mention of when the magic block was introduced as it seemed an odd piece of
archaeology to keep around when the guard paragraph was removed.
cheers ./daniel
Attachments:
pg_module_magic-v2.patch (application/octet-stream, 0B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Change wording for PG_MODULE_MAGIC inclusion
@ 2017-08-31 02:42 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
parent: Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Eisentraut @ 2017-08-31 02:42 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-docs
On 8/30/17 13:28, Daniel Gustafsson wrote:
>> On 30 Aug 2017, at 16:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> Uh, why would anybody be reading the pg10 docs in order to compile
>>> modules for 8.2? I vote to just drop the suggestion that there needs to
>>> be an #ifdef guard altogether.
>>
>> +1 ... if you are reading the current docs, they're going to tell you
>> lots of things that won't work in 8.1.
>
> Patch updated with dropping the #ifdef guard paragraph. Also removed the
> mention of when the magic block was introduced as it seemed an odd piece of
> archaeology to keep around when the guard paragraph was removed.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Change wording for PG_MODULE_MAGIC inclusion
@ 2017-08-31 04:56 Daniel Gustafsson <daniel@yesql.se>
parent: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Gustafsson @ 2017-08-31 04:56 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Alvaro Herrera <alvherre@2ndquadrant.com>; pgsql-docs
> On 31 Aug 2017, at 04:42, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>
> On 8/30/17 13:28, Daniel Gustafsson wrote:
>>> On 30 Aug 2017, at 16:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>
>>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>>> Uh, why would anybody be reading the pg10 docs in order to compile
>>>> modules for 8.2? I vote to just drop the suggestion that there needs to
>>>> be an #ifdef guard altogether.
>>>
>>> +1 ... if you are reading the current docs, they're going to tell you
>>> lots of things that won't work in 8.1.
>>
>> Patch updated with dropping the #ifdef guard paragraph. Also removed the
>> mention of when the magic block was introduced as it seemed an odd piece of
>> archaeology to keep around when the guard paragraph was removed.
>
> committed
Thanks!
cheers ./daniel
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2017-08-31 04:56 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 12:33 Change wording for PG_MODULE_MAGIC inclusion Daniel Gustafsson <daniel@yesql.se>
2017-08-30 14:35 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2017-08-30 14:51 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-08-30 17:28 ` Daniel Gustafsson <daniel@yesql.se>
2017-08-31 02:42 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-08-31 04:56 ` Daniel Gustafsson <daniel@yesql.se>
2017-08-30 14:52 ` Daniel Gustafsson <daniel@yesql.se>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox