public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: [email protected]
To: [email protected]
Subject: Re: pgrowlocks columns do not match docs: "modes" instead of "lock_type"
Date: Tue, 2 Oct 2018 16:41:52 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
On Mon, Oct 01, 2018 at 09:42:08AM +0000, PG Doc comments form wrote:
> The description of the pgrowlocks extension says that the function returns a
> column called "lock_type". However this column is really called "modes", as
> shown in contrib/pgrowlocks/pgrowlocks--1.2.sql:
>
> CREATE FUNCTION pgrowlocks(IN relname text,
> OUT locked_row TID, -- row TID
> OUT locker XID, -- locking XID
> OUT multi bool, -- multi XID?
> OUT xids xid[], -- multi XIDs
> OUT modes text[], -- multi XID statuses
> OUT pids INTEGER[]) -- locker's process id
> RETURNS SETOF record
> AS 'MODULE_PATHNAME', 'pgrowlocks'
> LANGUAGE C STRICT PARALLEL SAFE;
0ac5ad5 has updated pgrowlocks from 1.0 to 1.1 and it forgot the
documentation. The order of the columns is correct, but the example was
not. So I updated the documentation with a fresh one, and fixed it all
the way down to 9.3. Thanks for the report, Chris!
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgrowlocks columns do not match docs: "modes" instead of "lock_type"
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox