pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: Mark a reloption as indexterm
Date: Fri, 12 Apr 2019 12:52:29 +0900
Message-ID: <20190412035229.GF2144@paquier.xyz> (raw)
In-Reply-To: <CAHGQGwFvgZVMVKAZcrp1yw4i=Ds6T8Be2SsfJ=9PE-FhUcGmzg@mail.gmail.com>
References: <CAHGQGwHyKt9-xkibVguPzYqKgb_2tdw14Ub1XDTu08kyHMiTQA@mail.gmail.com>
	<20190409191133.GA18881@alvherre.pgsql>
	<CAHGQGwFvgZVMVKAZcrp1yw4i=Ds6T8Be2SsfJ=9PE-FhUcGmzg@mail.gmail.com>

On Fri, Apr 12, 2019 at 12:33:45PM +0900, Fujii Masao wrote:
> Indeed. Attached is the updated version of the patch.

On top of what Alvaro has mentioned, it seems to me that we should
make the difference between table-level configuration parameter and
index-level configuration parameters, and also add <primary> markups
to create_index.sgml.  If you take the example of fillfactor, it
applies to both indexes and tables, but with your patch you just
define "configuration parameter", and point to only CREATE TABLE.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (17+ messages)  latest in thread

Message-ID: <20190412035229.GF2144@paquier.xyz>
Permalink:  ../20190412035229.GF2144@paquier.xyz/
Also on:    postgresql.org/message-id/20190412035229.GF2144@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: michael@paquier.xyz, masao.fujii@gmail.com, alvherre@2ndquadrant.com
  Subject: Re: Mark a reloption as indexterm
  In-Reply-To: <20190412035229.GF2144@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox