From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: Clarification to pg_upgrade docs on reverting to old cluster
Date: Wed, 17 Apr 2019 18:01:44 -0400
Message-ID: <20190417220144.23ievs3hegisftop@momjian.us> (raw)
In-Reply-To: <BdGuM1D7YTQ0nM89CN1EhEr5Ic6aLVASSBd2mbdgB_peAGsKOnfpxrInh36d77oQp8y1JFQ88TiJoyMyu--hzHLIH4pWMsHYQocW5Xpo_PQ=@yesql.se>
References: <qtqiv7hI87s_Xvz5ZXHCaH-1-_AZGpIDJowzlRjF3-AbCr3RhSNydM_JCuJ8DE4WZozrtxhIWmyYTbv0syKyfGB6cYMQitp9yN-NZMm-oAo=@yesql.se>
<CABUevExh8f947ZP1a=Xki4M_EndakxbWuMOnDdVEH5BRMZC+DA@mail.gmail.com>
<ywhFn7QMoEFtC4Juck-QQ5i__Z6nxZGy5YwAirAmY0Bn55Mf0CEjAnnb3f2DHU5ARCAlFkry5w5FKEZgcnRebn8qAX3YDvOAURq-I_c4Ac8=@yesql.se>
<20190412014846.w4vcdhnmitry4yep@momjian.us>
<BdGuM1D7YTQ0nM89CN1EhEr5Ic6aLVASSBd2mbdgB_peAGsKOnfpxrInh36d77oQp8y1JFQ88TiJoyMyu--hzHLIH4pWMsHYQocW5Xpo_PQ=@yesql.se>
On Fri, Apr 12, 2019 at 06:53:14AM +0000, Daniel Gustafsson wrote:
> On Friday, April 12, 2019 3:48 AM, Bruce Momjian <bruce@momjian.us> wrote:
>
> > On Fri, Apr 5, 2019 at 02:23:22PM +0000, Daniel Gustafsson wrote:
> >
> > > On Friday, April 5, 2019 2:26 PM, Magnus Hagander magnus@hagander.net wrote:
> > > but wouldn't it sound better with "in this case" than "at this point"? And
> > > as a really small nitpick, restore from backup, rather than backups?
> > > Agreed.
> > >
> > > The third bulletpoint also seems quite complicated really. If we're
> > > tweaking these, wouldn't it be better if we split that one in two -- one
> > > for "if you ran it without --link", that should reallyi be listed above any
> > > of the other options?
> > >
> > >
> > > Looking at it closer I tend to agree, and updated the patch to split this up in
> > > an attempt to make it a bit clearer for newcomers to pg_upgrade. How about the
> > > attached version?
> >
> > I agree that current paragraph is terrible --- it is too dense and
> > confusing. I liked your sub-bullets. I adjusted your patch to tighten
> > the language, and reordered the entries to appear in the order the
> > actions would be performed.
> >
> > Updated patch attached.
>
> The order of the bullets is much better in your patch, thanks!
Patch applied and backpatched through 9.4. Thanks.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, daniel@yesql.se, magnus@hagander.net, pgsql-docs@lists.postgresql.org
Subject: Re: Clarification to pg_upgrade docs on reverting to old cluster
In-Reply-To: <20190417220144.23ievs3hegisftop@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox