pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedMinor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2019-04-22 b804c1837b cee3cfd75c 42b962176e 5241f68999 Fix documentation of pg_start_backup and pg_stop_backup functions.
* Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup
@ 2019-04-18 15:38 Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Fujii Masao @ 2019-04-18 15:38 UTC (permalink / raw)
To: pgsql-docs
Hi,
> These functions cannot be executed during recovery (except
> <function>pg_is_in_backup</function>, <function>pg_backup_start_time</function>
> and <function>pg_wal_lsn_diff</function>).
Regarding backup control functions, the func.sgml describes as above.
But non-exclusive pg_start_backup and pg_stop_backup can also be
executed during recovery, and which should be described in the doc.
So I think that the attached patch should be pushed. Thought?
Probably the patch needs to be back-patched to 9.6 where non-exclusive
backup API was added.
Regards,
--
Fujii Masao
Attachments:
backup-doc.patch (application/octet-stream, 616B) download
*** a/doc/src/sgml/func.sgml
--- b/doc/src/sgml/func.sgml
***************
*** 19835,19840 **** SELECT set_config('log_statement_stats', 'off', false);
--- 19835,19842 ----
The functions shown in <xref
linkend="functions-admin-backup-table"/> assist in making on-line backups.
These functions cannot be executed during recovery (except
+ non-exclusive <function>pg_start_backup</function>,
+ non-exclusive <function>pg_stop_backup</function>,
<function>pg_is_in_backup</function>, <function>pg_backup_start_time</function>
and <function>pg_wal_lsn_diff</function>).
</para>
* Re: Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup
@ 2019-04-19 02:36 Michael Paquier <michael@paquier.xyz>
parent: Fujii Masao <masao.fujii@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2019-04-19 02:36 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@gmail.com>; +Cc: pgsql-docs
On Fri, Apr 19, 2019 at 12:38:23AM +0900, Fujii Masao wrote:
> Regarding backup control functions, the func.sgml describes as above.
> But non-exclusive pg_start_backup and pg_stop_backup can also be
> executed during recovery, and which should be described in the doc.
> So I think that the attached patch should be pushed. Thought?
>
> Probably the patch needs to be back-patched to 9.6 where non-exclusive
> backup API was added.
+1.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup
@ 2019-04-22 17:46 Fujii Masao <masao.fujii@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 3+ messages in thread
From: Fujii Masao @ 2019-04-22 17:46 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs
On Fri, Apr 19, 2019 at 11:36 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Apr 19, 2019 at 12:38:23AM +0900, Fujii Masao wrote:
> > Regarding backup control functions, the func.sgml describes as above.
> > But non-exclusive pg_start_backup and pg_stop_backup can also be
> > executed during recovery, and which should be described in the doc.
> > So I think that the attached patch should be pushed. Thought?
> >
> > Probably the patch needs to be back-patched to 9.6 where non-exclusive
> > backup API was added.
>
> +1.
Thanks! Committed.
Regards,
--
Fujii Masao
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-04-22 17:46 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18 15:38 Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup Fujii Masao <masao.fujii@gmail.com>
2019-04-19 02:36 ` Michael Paquier <michael@paquier.xyz>
2019-04-22 17:46 ` Fujii Masao <masao.fujii@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox