From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: emorley@heroku.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: PostgreSQL 12 release notes missing breaking change in libpq
Date: Wed, 23 Oct 2019 22:05:44 -0400
Message-ID: <20191024020544.GD8650@momjian.us> (raw)
In-Reply-To: <20191017013310.GC5605@paquier.xyz>
References: <157123155668.25311.9369950798665566339@wrigleys.postgresql.org>
<20191017013310.GC5605@paquier.xyz>
On Thu, Oct 17, 2019 at 10:33:10AM +0900, Michael Paquier wrote:
> On Wed, Oct 16, 2019 at 01:12:36PM +0000, PG Doc comments form wrote:
> > In PostgreSQL 12, libpq's parsing of connection string integer parameters
> > was made more strict, such that invalid values now result in an error rather
> > than being silently ignored:
> > https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
> >
> > This change resulted in runtime errors/crashes for some of our customers
> > after we upgraded the Heroku stack images to use v12 of the PostgreSQL
> > client libs.
> >
> > We had checked the release notes, but it's not currently mentioned:
> > https://www.postgresql.org/docs/12/release-12.html
> >
> > Please could it be added?
>
> I think it makes sense to mention that. Bruce, why not adding an item
> about that in the "Migration to Version 12" section? Was that
> intentionally left out?
My reading of the commit message is that the error messages will just be
more helpful now, not that some things would now error that use to be
ignored. I am still unclear exactly what the release notes should say.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, michael@paquier.xyz, emorley@heroku.com, pgsql-docs@lists.postgresql.org
Subject: Re: PostgreSQL 12 release notes missing breaking change in libpq
In-Reply-To: <20191024020544.GD8650@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox