public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?
Date: Tue, 5 Nov 2019 13:27:16 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Mon, Nov 04, 2019 at 09:52:34PM -0500, Bruce Momjian wrote:
> The default _value_ is 60 seconds, and we use the 's' to specify
> seconds. What the comment is saying is that if you _don't_ specify any
> units, the integer is in milliseconds. I am not sure how to improve
> that.
I do have a suggestion as per the attached, say:
+#wal_sender_timeout = 60s # in milliseconds if no unit specified;
+ # 0 disables
--
Michael
Attachments:
[text/x-diff] pgconf-units.patch (1.1K, 2-pgconf-units.patch)
download | inline diff:
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 0fc23e3a61..eea017e840 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -286,7 +286,8 @@
#max_wal_senders = 10 # max number of walsender processes
# (change requires restart)
#wal_keep_segments = 0 # in logfile segments; 0 disables
-#wal_sender_timeout = 60s # in milliseconds; 0 disables
+#wal_sender_timeout = 60s # in milliseconds if no unit specified;
+ # 0 disables
#max_replication_slots = 10 # max number of replication slots
# (change requires restart)
@@ -326,7 +327,8 @@
# query conflicts
#wal_receiver_timeout = 60s # time that receiver waits for
# communication from master
- # in milliseconds; 0 disables
+ # in milliseconds if no unit specified;
+ # 0 disables
#wal_retrieve_retry_interval = 5s # time to wait before retrying to
# retrieve WAL after a failed attempt
#recovery_min_apply_delay = 0 # minimum delay for applying changes during recovery
[application/pgp-signature] signature.asc (833B, 3-signature.asc)
download
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox