public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Example not producing shown output
Date: Tue, 26 Nov 2019 15:28:18 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On 2019-Nov-25, Daniel Gustafsson wrote:

> > On 25 Nov 2019, at 13:05, PG Doc comments form <[email protected]> wrote:

> > Examples should have specified 'english'.
> > 
> > Instead:
> >   to_tsvector('fat cats ate rats') @@ to_tsquery('cat & rat')
> > 
> > which returns fale on my own blank installation of Postgre (Serbian locale
> > Windows OS) instead of true:
> >   to_tsvector('english', 'fat cats ate rats') @@ to_tsquery('cat & rat')
> 
> I agree with this complaint, mainly since other examples on the page do specify
> english where required AFAICT, this makes it consistent.

Hmm.  I'm not sure that it's an improvement to make all the examples
alike; that means we would not provide examples of the simpler syntax.
And because other examples already show that it's possible to indicate
the language, I'm not sure it's strictly necessary to do so here.

Maybe this complaint could be addressed by indicating in a note that
some examples might not work identically if run under a different
locale.  Or perhaps we can add a second line in the example cell for the
@@ operator, to make it clear that both forms can be used.  Users can be
expected to apply some intuition from that point onwards.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Example not producing shown output
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox