From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: osdba <mailtch@163.com>
Cc: pgsql-docs@postgresql.org
Cc: jkatz@postgresql.org
Subject: Re: Document "59.2. Built-in Operator Classes" have a clerical error?
Date: Fri, 28 Aug 2020 17:02:16 +0900
Message-ID: <20200828080216.GA20757@paquier.xyz> (raw)
In-Reply-To: <3379567.1598577159@sss.pgh.pa.us>
References: <20200827160751.GA882@alvherre.pgsql>
<3379567.1598577159@sss.pgh.pa.us>
On Thu, Aug 27, 2020 at 09:12:39PM -0400, Tom Lane wrote:
> I did not verify that the correct operators are listed, but visually
> it looks OK.
>
> One thing I've noted in working with this stuff is that (at least for me)
> HTML seems to default to valign=center while PDF defaults to valign=top.
> You can see that in these tables in the positioning of the opclass names.
> For myself, valign=center looks better in these cases so I'd suggest
> adding <colspec>s to force it that way. Or, if you like valign=top,
> we should do that --- but it ought to be consistent across output formats.
Yes. valign="center" does not exist, but I like your idea to use
"middle" here and make things consistent between the PDF and HTML
outputs. So I have used this option for the cells where this applies,
and committed the patch. Thanks all for the discussion and the
successive reviews.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, bruce@momjian.us, mailtch@163.com, jkatz@postgresql.org
Subject: Re: Document "59.2. Built-in Operator Classes" have a clerical error?
In-Reply-To: <20200828080216.GA20757@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox