From: Bruce Momjian <bruce@momjian.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Guyren Howe <guyren@gmail.com>
Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Please provide examples of rows from
Date: Wed, 30 Sep 2020 13:54:32 -0400
Message-ID: <20200930175432.GB26841@momjian.us> (raw)
In-Reply-To: <CAKFQuwa=dXV4a_Hm=PfufJkhDR4uFwiG+ON-ea5wp=BGBJHQtQ@mail.gmail.com>
References: <CAKFQuwbBDr22KJRyJQRECO_XU6cyouwz3ocn0Tv4JgG4Gm5hMQ@mail.gmail.com>
<20200920003910.GA22746@momjian.us>
<798909.1600562993@sss.pgh.pa.us>
<20200920013846.GC22746@momjian.us>
<835988.1600613834@sss.pgh.pa.us>
<878265.1600625640@sss.pgh.pa.us>
<20200924185511.GC22807@momjian.us>
<1668963.1600974324@sss.pgh.pa.us>
<20200924193714.GD22807@momjian.us>
<CAKFQuwa=dXV4a_Hm=PfufJkhDR4uFwiG+ON-ea5wp=BGBJHQtQ@mail.gmail.com>
On Tue, Sep 29, 2020 at 08:53:51PM -0700, David G. Johnston wrote:
> On Thu, Sep 24, 2020 at 12:37 PM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Thu, Sep 24, 2020 at 03:05:24PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Yes, this is very helpful. I was afraid the JSON would overwhelm the
> > > example, but this looks good. I wrote the attached doc patch which I
> > > think improves this. I plan to apply it to all supported versions.
> >
> > Couple thoughts:
> >
> > * Taking the initial ... out of the syntax synopsis is not an
> improvement.
> > It makes it look like you can only apply AS to the first function of a
> > ROWS FROM.
>
> Oh, so the dots represent optional non-column_definition function calls.
> I can't think if a cleaner way to show that, so I guess "..." will have
> to do.
>
>
> My original comment was a question predicated upon the fact that the SELECT
> reference page doesn't include the leading; probably should add them there as
> part of this patch.
I looked at that but in the SELECT manual page case, the example is
already part of a larger list of options so I don't think it is needed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, david.g.johnston@gmail.com, tgl@sss.pgh.pa.us, guyren@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Please provide examples of rows from
In-Reply-To: <20200930175432.GB26841@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox