From: Bruce Momjian <bruce@momjian.us>
To: e.indrupskaya@postgrespro.ru
To: pgsql-docs@lists.postgresql.org
Subject: Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
Date: Tue, 27 Oct 2020 12:47:24 -0400
Message-ID: <20201027164724.GN4951@momjian.us> (raw)
In-Reply-To: <160379609706.24746.7506163279454026608@wrigleys.postgresql.org>
References: <160379609706.24746.7506163279454026608@wrigleys.postgresql.org>
On Tue, Oct 27, 2020 at 10:54:57AM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/13/libpq-threading.html
> Description:
>
> On page https://www.postgresql.org/docs/13/libpq-exec.html, non-existing
> directory is mentioned: src/tools/thread.
Good find. This directory was removed last week in this commit:
commit 8a2121185b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed Oct 21 12:08:48 2020 -0400
Remove the option to build thread_test.c outside configure.
Theoretically one could go into src/test/thread and build/run this
program there. In practice, that hasn't worked since 96bf88d52,
and probably much longer on some platforms (likely including just
the sort of hoary leftovers where this test might be of interest).
While it wouldn't be too hard to repair the breakage, the fact that
nobody has noticed for two years shows that there is zero usefulness
in maintaining this build pathway. Let's get rid of it and decree
that thread_test.c is *only* meant to be built/used in configure.
Given that decision, it makes sense to put thread_test.c under config/
and get rid of src/test/thread altogether, so that's what I did.
In passing, update src/test/README, which had been ignored by some
not-so-recent additions of subdirectories.
Discussion: https://postgr.es/m/227659.1603041612@sss.pgh.pa.us
I have applied the attached patch to all branches to remove the
paragraph. I think the docs are only built when there is a minor
release, so it might take a few weeks until the online docs are updated.
You found this very quickly. :-)
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:master.diff (text/x-diff, 743B) downloaddiff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgmlindex de60281fcb..9ce32fb39b 100644--- a/doc/src/sgml/libpq.sgml+++ b/doc/src/sgml/libpq.sgml@@ -8052,14 +8052,6 @@ int PQisthreadsafe();
<application>libpq</application> source code for a way to do cooperative
locking between <application>libpq</application> and your application.
</para>
-- <para>- If you experience problems with threaded applications, run the program- in <filename>src/tools/thread</filename> to see if your platform has- thread-unsafe functions. This program is run by- <filename>configure</filename>, but for binary distributions your- library might not match the library used to build the binaries.- </para>
</sect1>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, e.indrupskaya@postgrespro.ru, pgsql-docs@lists.postgresql.org
Subject: Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
In-Reply-To: <20201027164724.GN4951@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox