From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: b1000101@pm.me
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: max_slot_wal_keep_size unit is not specified
Date: Fri, 26 Nov 2021 14:36:25 -0300
Message-ID: <202111261736.dkjpdm2suijl@alvherre.pgsql> (raw)
In-Reply-To: <20211126.160309.2183888631128649991.horikyota.ntt@gmail.com>
On 2021-Nov-26, Kyotaro Horiguchi wrote:
> Regarding the proposed description, we have never explained how the
> same kind of values specified in megabytes is converted into internal
> units. If we add that explanation there, we might want the same for
> max_wal_size, min_wal_size and wal_keep_size.
True. Since this was for backpatch, it seemed best to copy the existing
entries instead of changing them.
> The same section starts with the following sentences.
>
> > Specify the maximum size of WAL files
> > that <link linkend="streaming-replication-slots">replication
> > slots</link> are allowed to retain in the <filename>pg_wal</filename>
> > directory at checkpoint time.
>
> FWIW I thought (or intended) that "the maximum size of WAL files that
> slots are *allowed to retain*" connotes the same to the sentences
> cited above.
Right you are -- that addition was redundant, so I pushed without that.
> Premising "16 MB one way or the other don't change things much", I'm
> not sure we really need to be particular about a few megabites
> difference especially only for this specific variable.
Yeah.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: alvherre@alvh.no-ip.org, horikyota.ntt@gmail.com, b1000101@pm.me, pgsql-docs@lists.postgresql.org
Subject: Re: max_slot_wal_keep_size unit is not specified
In-Reply-To: <202111261736.dkjpdm2suijl@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox