pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedIncorrect grammar in 15.2
3+ messages / 3 participants
[nested] [flat]
* Incorrect grammar in 15.2
@ 2024-07-24 05:11 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: PG Doc comments form @ 2024-07-24 05:11 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: grantgryczan@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/when-can-parallel-query-be-used.html
Description:
Unless I'm misunderstanding the sentence structure here, I believe the word
"a" is missing before "parallel query plan" in the following sentence from
section 15.2:
> Even when parallel query plan is generated for a particular query, there
are several circumstances under which it will be impossible to execute that
plan in parallel at execution time.
This should say:
> Even when a parallel query plan is generated for a particular query, there
are several circumstances under which it will be impossible to execute that
plan in parallel at execution time.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Incorrect grammar in 15.2
@ 2024-07-24 10:52 Laurenz Albe <laurenz.albe@cybertec.at>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Laurenz Albe @ 2024-07-24 10:52 UTC (permalink / raw)
To: grantgryczan@gmail.com; pgsql-docs@lists.postgresql.org
On Wed, 2024-07-24 at 05:11 +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/when-can-parallel-query-be-used.html
> Description:
>
> Unless I'm misunderstanding the sentence structure here, I believe the word
> "a" is missing before "parallel query plan" in the following sentence from
> section 15.2:
>
> > Even when parallel query plan is generated for a particular query, there
> are several circumstances under which it will be impossible to execute that
> plan in parallel at execution time.
>
> This should say:
>
> > Even when a parallel query plan is generated for a particular query, there
> are several circumstances under which it will be impossible to execute that
> plan in parallel at execution time.
+1
Here is a patch for that; it may be the smallest patch I've ever
written for PostgreSQL.
Yours,
Laurenz Albe
Attachments:
[text/x-patch] v1-0001-Fix-a-missing-article-in-the-documentation.patch (1.0K, ../../054ae54ad248783aefeb59813080d29faad5a11f.camel@cybertec.at/2-v1-0001-Fix-a-missing-article-in-the-documentation.patch)
download | inline diff:
From 68eedd01c754ffd2dfbb11cd29f568841d7db7a6 Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.albe@cybertec.at>
Date: Wed, 24 Jul 2024 12:50:49 +0200
Subject: [PATCH v1] Fix a missing article in the documentation
Per complaint from Grant Gryczan.
---
doc/src/sgml/parallel.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/parallel.sgml b/doc/src/sgml/parallel.sgml
index dae9dd7f2f..590cb385dd 100644
--- a/doc/src/sgml/parallel.sgml
+++ b/doc/src/sgml/parallel.sgml
@@ -202,7 +202,7 @@ EXPLAIN SELECT * FROM pgbench_accounts WHERE filler LIKE '%x%';
</itemizedlist>
<para>
- Even when parallel query plan is generated for a particular query, there
+ Even when a parallel query plan is generated for a particular query, there
are several circumstances under which it will be impossible to execute
that plan in parallel at execution time. If this occurs, the leader
will execute the portion of the plan below the <literal>Gather</literal>
--
2.45.2
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Incorrect grammar in 15.2
@ 2024-07-24 12:15 Alvaro Herrera <alvherre@alvh.no-ip.org>
parent: Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 0 replies; 3+ messages in thread
From: Alvaro Herrera @ 2024-07-24 12:15 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: grantgryczan@gmail.com; pgsql-docs@lists.postgresql.org
On 2024-Jul-24, Laurenz Albe wrote:
> Here is a patch for that; it may be the smallest patch I've ever
> written for PostgreSQL.
Thanks, applied.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-07-24 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-24 05:11 Incorrect grammar in 15.2 PG Doc comments form <noreply@postgresql.org>
2024-07-24 10:52 ` Laurenz Albe <laurenz.albe@cybertec.at>
2024-07-24 12:15 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox