public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Tomonari Katsumata <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: disabling log_rotation_age feature.
Date: Thu, 12 Jun 2014 10:41:35 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwEPVu2T39Zddvh-CubJ9Ghyz4Gf1-JGqqvu5Ja7m5BJ7w@mail.gmail.com>
References: <[email protected]>
	<CAHGQGwEPVu2T39Zddvh-CubJ9Ghyz4Gf1-JGqqvu5Ja7m5BJ7w@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

Fujii Masao <[email protected]> writes:
> On Thu, Jun 12, 2014 at 1:43 PM, Tomonari Katsumata
> <[email protected]> wrote:
>> The document tells us to set it to ZERO if we want to disable the feature.
>> However, the feature would be disabled if we set it less than one minute.

> That's because log_rotation_age expects the setting value in minutes.

> This is not a problem only for log_rotation_age. When setting the parameter
> which expects the value in seconds to less than one second, the setting value
> is implicitly reset to the default.

It's not "reset to default", it's set to zero due to rounding the fraction
down.  Some GUCs interpret zero specially, some don't.

I wonder if we should round fractions up instead of down in that logic?
It might be less surprising for those GUCs where zero is special, and
it seems like about a wash for most others.

			regards, tom lane


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: disabling log_rotation_age feature.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox