public inbox for [email protected]
help / color / mirror / Atom feed66.6. Database Page Layout
3+ messages / 3 participants
[nested] [flat]
* 66.6. Database Page Layout
@ 2026-07-08 10:43 PG Doc comments form <[email protected]>
2026-07-09 21:58 ` Re: 66.6. Database Page Layout Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: PG Doc comments form @ 2026-07-08 10:43 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/18/storage-page-layout.html
Description:
> The second field contains the page checksum if -k are enabled.
-k -- This is enabled by default; use --no-data-checksums to disable
checksums.
Why does this need to be clarified?
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: 66.6. Database Page Layout
2026-07-08 10:43 66.6. Database Page Layout PG Doc comments form <[email protected]>
@ 2026-07-09 21:58 ` Daniel Gustafsson <[email protected]>
2026-07-10 06:33 ` Re: 66.6. Database Page Layout Laurenz Albe <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Gustafsson @ 2026-07-09 21:58 UTC (permalink / raw)
To: [email protected]; PostgreSQL-documentation <[email protected]>
> On 8 Jul 2026, at 12:43, PG Doc comments form <[email protected]> wrote:
>
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/18/storage-page-layout.html
> Description:
>
>> The second field contains the page checksum if -k are enabled.
>
> -k -- This is enabled by default; use --no-data-checksums to disable
> checksums.
>
> Why does this need to be clarified?
I'm not entirely sure which part you are referring to, but I agree that the
current wording isn't very good.
"The second field contains the page checksum if -k are enabled."
I propose the attached patch which changes the sentence to "The second field
contains the page checksum if data checksums are enabled." with a link to the
Checksums chapter in the documentation instead.
--
Daniel Gustafsson
Attachments:
[application/octet-stream] page_layout_checksums.diff (783B, ../../[email protected]/2-page_layout_checksums.diff)
download | inline diff:
diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml/storage.sgml
index 6b6377503bf..19924b98d71 100644
--- a/doc/src/sgml/storage.sgml
+++ b/doc/src/sgml/storage.sgml
@@ -797,7 +797,7 @@ data. Empty in ordinary tables.</entry>
(<structname>PageHeaderData</structname>). Its format is detailed in <xref
linkend="pageheaderdata-table"/>. The first field tracks the most
recent WAL entry related to this page. The second field contains
- the page checksum if <xref linkend="app-initdb-data-checksums"/> are
+ the page checksum if <link linkend="checksums">data checksums</link> are
enabled. Next is a 2-byte field containing flag bits. This is followed
by three 2-byte integer fields (<structfield>pd_lower</structfield>,
<structfield>pd_upper</structfield>, and
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: 66.6. Database Page Layout
2026-07-08 10:43 66.6. Database Page Layout PG Doc comments form <[email protected]>
2026-07-09 21:58 ` Re: 66.6. Database Page Layout Daniel Gustafsson <[email protected]>
@ 2026-07-10 06:33 ` Laurenz Albe <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Laurenz Albe @ 2026-07-10 06:33 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; [email protected]; PostgreSQL-documentation <[email protected]>
On Thu, 2026-07-09 at 23:58 +0200, Daniel Gustafsson wrote:
>
> I propose the attached patch which changes the sentence to "The second field
> contains the page checksum if data checksums are enabled." with a link to the
> Checksums chapter in the documentation instead.
That patch looks good to me.
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-07-10 06:33 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-08 10:43 66.6. Database Page Layout PG Doc comments form <[email protected]>
2026-07-09 21:58 ` Daniel Gustafsson <[email protected]>
2026-07-10 06:33 ` Laurenz Albe <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox