public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Ian Barwick <[email protected]>
Cc: [email protected]
Subject: Re: Minor doc correction for SPI_execute_with_args
Date: Sat, 30 May 2015 13:57:29 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>
Ian Barwick <[email protected]> writes:
> The documentation for SPI_execute_with_args:
> http://www.postgresql.org/docs/current/static/spi-spi-execute-with-args.html
> claims it returns the same value as SPI_execute, whereas it actually
> calls SPI_execute_plan which can produce two additional error codes.
But SPI_execute also calls _SPI_execute_plan. Moreover, the documented
reasons for SPI_execute_plan to return additional error codes don't match
up too closely with SPI_execute_with_args (eg, there's no "plan"
argument, so saying "plan was prepared with some parameters" is pretty
meaningless here).
If what you're looking at is the extra error conditions right at the start
of SPI_execute_with_args, my inclination would be to document them without
any reference to SPI_execute_plan, ie we'd add text much like what's
under SPI_execute_plan but with the descriptions of the error codes
adjusted to agree with this function.
regards, tom lane
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Minor doc correction for SPI_execute_with_args
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox