pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feed11.7 Indexes on Expressions: editorial correction
3+ messages / 3 participants
[nested] [flat]
* 11.7 Indexes on Expressions: editorial correction
@ 2020-05-19 10:54 PG Doc comments form <noreply@postgresql.org>
2020-05-19 14:32 ` Re: 11.7 Indexes on Expressions: editorial correction Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: PG Doc comments form @ 2020-05-19 10:54 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: farmernick-pg@varteg.nz
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/12/indexes-expressional.html
Description:
The paragraph that begins "If we were to declare this index UNIQUE,..."
refers to the index test1_lower_col1_idx, not to the test1_uniq_int index it
currently follows. It would appear the latter example was spliced into the
middle of discussing the former.
The paragraphs should be ordered:
CREATE INDEX test1_lower_col1_idx ....
If we were to declare this index UNIQUE, ...
Expression indexes also allow control....
CREATE UNIQUE INDEX test1_uniq_int ...
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: 11.7 Indexes on Expressions: editorial correction
2020-05-19 10:54 11.7 Indexes on Expressions: editorial correction PG Doc comments form <noreply@postgresql.org>
@ 2020-05-19 14:32 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-05-21 23:50 ` Re: 11.7 Indexes on Expressions: editorial correction Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2020-05-19 14:32 UTC (permalink / raw)
To: farmernick-pg@varteg.nz; +Cc: pgsql-docs@lists.postgresql.org, Bruce Momjian <bruce@momjian.us>
PG Doc comments form <noreply@postgresql.org> writes:
> The paragraph that begins "If we were to declare this index UNIQUE,..."
> refers to the index test1_lower_col1_idx, not to the test1_uniq_int index it
> currently follows. It would appear the latter example was spliced into the
> middle of discussing the former.
Yes, this was complained of before:
https://www.postgresql.org/message-id/flat/E1ikvbp-0005jW-E9%40gemulon.postgresql.org
I remain of the opinion that we'd be best off to just revert
a9760d0f3 altogether. Bruce's last proposal mostly did that,
but it still insisted on muddying an existing example with an
unrelated comment.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: 11.7 Indexes on Expressions: editorial correction
2020-05-19 10:54 11.7 Indexes on Expressions: editorial correction PG Doc comments form <noreply@postgresql.org>
2020-05-19 14:32 ` Re: 11.7 Indexes on Expressions: editorial correction Tom Lane <tgl@sss.pgh.pa.us>
@ 2020-05-21 23:50 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Momjian @ 2020-05-21 23:50 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: farmernick-pg@varteg.nz; pgsql-docs@lists.postgresql.org
On Tue, May 19, 2020 at 10:32:01AM -0400, Tom Lane wrote:
> PG Doc comments form <noreply@postgresql.org> writes:
> > The paragraph that begins "If we were to declare this index UNIQUE,..."
> > refers to the index test1_lower_col1_idx, not to the test1_uniq_int index it
> > currently follows. It would appear the latter example was spliced into the
> > middle of discussing the former.
>
> Yes, this was complained of before:
>
> https://www.postgresql.org/message-id/flat/E1ikvbp-0005jW-E9%40gemulon.postgresql.org
>
> I remain of the opinion that we'd be best off to just revert
> a9760d0f3 altogether. Bruce's last proposal mostly did that,
> but it still insisted on muddying an existing example with an
> unrelated comment.
Muddy patch applied. ;-) I am open to clarifying it but I think we
need something in our docs about this idea.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2020-05-21 23:50 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 10:54 11.7 Indexes on Expressions: editorial correction PG Doc comments form <noreply@postgresql.org>
2020-05-19 14:32 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-05-21 23:50 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox