public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: PostgreSQL-development <[email protected]>
To: [email protected]
Subject: Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION
Date: Mon, 15 Feb 2010 18:40:36 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Thu, Feb 4, 2010 at 4:28 PM, Fujii Masao <[email protected]> wrote:
> Sorry for resurrecting an old argument.
> http://archives.postgresql.org/message-id/[email protected]
>
> I got the complaint about this behavior of the current pg_stop_backup()
> in this morning. I thought that this is the bug, and created the patch.
> But it was rejected because its change might break the existing app.
> Though I'm not sure if there is really such an app. Anyway I think that
> something like the following statements should be added into the document.
> Thought?
>
> ------------
> Note that the WAL file name in the backup history file cannot be used
> to determine which WAL files are required for the backup. Because it
> indicates the subsequent WAL file of the starting or ending one for
> the backup, when its location is exactly at a WAL file boundary (What
> is worse, sometimes it indicates a nonexistent WAL file).
> ------------

Here is the patch that adds the above-mentioned note. I think this
should be back-patched up to 8.0. Thought?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Attachments:

  [text/x-patch] note_backup_history_file_0215.patch (689B, 2-note_backup_history_file_0215.patch)
  download | inline diff:
*** a/doc/src/sgml/backup.sgml
--- b/doc/src/sgml/backup.sgml
***************
*** 859,864 **** SELECT pg_stop_backup();
--- 859,869 ----
      If you used the label to identify the associated dump file,
      then the archived history file is enough to tell you which dump file to
      restore.
+     Note that the WAL file name in the backup history file cannot be used
+     to determine which WAL files are required for the backup. Because it
+     indicates the subsequent WAL file of the starting or ending one for
+     the backup, when its location is exactly at a WAL file boundary (What
+     is worse, sometimes it indicates a nonexistent WAL file).
     </para>
  
     <para>

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [BUGS] BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox