From: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Curt Kolovson <ckolovson@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html
Date: Mon, 17 Jul 2023 22:36:46 -0400
Message-ID: <4124246.1689647806@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKFQuwZ=pA_pNhvVFn-Cdto2vXbdFRJif8mXb4MB5PT5-KUGvQ@mail.gmail.com>
References: <CANhYJV6HWtgz_qjx_APfK0PAgLUzY-2vjLuj7i_o=TZF1LAQew@mail.gmail.com>
<CAKFQuwbN7gzyEh-LBkXh+68xH8NS3QumYG8Tj6XVzG6zDvSuWg@mail.gmail.com>
<4114624.1689643322@sss.pgh.pa.us>
<CAKFQuwZ=pA_pNhvVFn-Cdto2vXbdFRJif8mXb4MB5PT5-KUGvQ@mail.gmail.com>
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Mon, Jul 17, 2023 at 6:22 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think his point is that this example does not behave as the
>> documentation claims. Which it does not, according to my
>> tests here. I find this a bit disturbing --- did we intentionally
>> change the behavior of SPI_exec somewhere along the line?
> Appears to be a documentation fix oversight back in v9.0
> https://github.com/postgres/postgres/commit/2ddc600f8f0252a0864e85d5cc1eeb3b9687d7e9
Ah, thanks for the pointer. I'd just been trying to bisect where
between 8.4 and 9.0 it changed, but failed because early-9.0 versions
don't build at all with current bison :-(
Anyway, given that the example needs updating, how should we do that
exactly? Is it worth demonstrating both the behavior with RETURNING
and that without? If not, which one to show?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, ckolovson@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html
In-Reply-To: <4124246.1689647806@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox