From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: eric.mutta@gmail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of PROGRAM parameter for the COPY command
Date: Sun, 21 Aug 2022 14:48:34 -0400
Message-ID: <4169601.1661107714@sss.pgh.pa.us> (raw)
In-Reply-To: <1DC6647E-45CF-4ECD-BAB5-0CC0626AF121@yesql.se>
References: <166104548566.654.11680826843612576896@wrigleys.postgresql.org>
<1DC6647E-45CF-4ECD-BAB5-0CC0626AF121@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> On 21 Aug 2022, at 03:31, PG Doc comments form <noreply@postgresql.org> wrote:
>> ...so if you need to pass any arguments to shell command that come
>> from an untrusted source...
>>
>> The "to shell command that come" part should be changed so it either reads
>> like this:
>>
>> ...so if you need to pass any arguments to a shell command that comes
>> from an untrusted source...
>>
>> ...or it reads like this:
>>
>> ...so if you need to pass any arguments to shell commands that come
>> from an untrusted source...
> Not being a native english speaker, but since we're already referring to "the
> command" in the sentence it seems more natural to me to change to "the shell
> command".
Hmm ... to me the main problem with this fragment is that it's not
entirely clear whether we're speaking of untrusted arguments or an
untrusted shell command, ie which one is the antecedent of "that".
The proposed variants seem to make that worse not better. I suggest
rephrasing like
... so if you need to include any shell command arguments that come from
an untrusted source, you must ...
Or maybe even better, just drop "shell command" from that phrase
altogether.
Probably also s/passing/including/ in the next sentence.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, eric.mutta@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of PROGRAM parameter for the COPY command
In-Reply-To: <4169601.1661107714@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox