pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: samantaswarnava1@gmail.com <samantaswarnava1@gmail.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: Small correction in chown command to set the owner of the pgsql data dir correctly
Date: Sun, 07 Feb 2021 11:25:34 -0500
Message-ID: <443848.1612715134@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKFQuwaaW_WmqOU+ZV3qJ6jcq1_Qo6yWCTXSerf-dT10JYKHmQ@mail.gmail.com>
References: <161268042200.663.5503825431641757282@wrigleys.postgresql.org>
	<CAKFQuwaaW_WmqOU+ZV3qJ6jcq1_Qo6yWCTXSerf-dT10JYKHmQ@mail.gmail.com>

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Saturday, February 6, 2021, PG Doc comments form <noreply@postgresql.org>
> wrote:
>> "root# mkdir /usr/local/pgsql
>> root# chown postgres /usr/local/pgsql
>> root# su postgres
>> postgres$ initdb -D /usr/local/pgsql/data"
>> If these steps are followed then it still fails to initialize the DB as
>> chown only gives ownership to the pgsql directory but not the child
>> directories under pgsql,

> If you follow those four steps exclusively then at the fourth step there
> are no child directories since step one created the pgsql directory and
> neither step two nor three created any other directories.

Yeah.  The OP must have followed some other process in order to get to

>> fixing permissions on existing directory /usr/local/pgsql/data ... initdb:
>> error: could not change permissions of directory "/usr/local/pgsql/data":
>> Operation not permitted"

More to the point, it seems to me that recommending "chown -R" on the
*parent* directory is not merely unsafe but an actual security hole.
There are plenty of scenarios where the data directory's parent ought
not be owned by the postgres user, and any other child directories even
less so.  An example is where the parent is a filesystem mount point.
(Admittedly, the manual does suggest adding an intermediate level
of postgres-owned directory in such a case, but lots of people don't
bother.)

If we're going to have people picking and choosing which parts of that
script they're going to follow exactly, having a step in it that's as
dangerous as "chown -R" just seems like a really bad idea.

			regards, tom lane





view thread (3+ messages)

Message-ID: <443848.1612715134@sss.pgh.pa.us>
Permalink:  ../443848.1612715134@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/443848.1612715134@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, samantaswarnava1@gmail.com, pgsql-docs@lists.postgresql.org
  Subject: Re: Small correction in chown command to set the owner of the pgsql data dir correctly
  In-Reply-To: <443848.1612715134@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox