public inbox for [email protected]
help / color / mirror / Atom feedImprove pg_restore docs
5+ messages / 3 participants
[nested] [flat]
* Improve pg_restore docs
@ 2009-06-29 18:15 Mike Toews <[email protected]>
2009-06-29 18:25 ` Re: Improve pg_restore docs Greg Smith <[email protected]>
2010-02-24 16:28 ` Re: Improve pg_restore docs Bruce Momjian <[email protected]>
0 siblings, 2 replies; 5+ messages in thread
From: Mike Toews @ 2009-06-29 18:15 UTC (permalink / raw)
To: pgsql-docs
Hi,
From a quick discussion on hackers
(http://archives.postgresql.org/pgsql-hackers/2009-06/msg01434.php), it
appears the documentation can improve for pg_restore.
I've prepared some quick diff output from
pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think
would help. Note that I'm not entirely sure about the default namespace
from default_path .. please verify this before accepting. Edit as necessary.
291c291,292
< specific table.
---
> specific table. The default is taken from the
> <envar>default_path</envar> variable.
379c380,382
< Restore definition and/or data of named table only.
---
> Restore definition and/or data of named table only. This can be
> combined with the <option>-n</option> option to restore a table
> from a specific schema.
Thanks,
-Mike
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Improve pg_restore docs
2009-06-29 18:15 Improve pg_restore docs Mike Toews <[email protected]>
@ 2009-06-29 18:25 ` Greg Smith <[email protected]>
2009-06-29 18:31 ` Re: Improve pg_restore docs Mike Toews <[email protected]>
1 sibling, 1 reply; 5+ messages in thread
From: Greg Smith @ 2009-06-29 18:25 UTC (permalink / raw)
To: Mike Toews <[email protected]>; +Cc: pgsql-docs
On Mon, 29 Jun 2009, Mike Toews wrote:
> I've prepared some quick diff output from
> pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think would
> help.
The standard way to submit patches here is to attach a file with a full
context diff (diff -c) to the message, rather than putting it inline or
including just the changes. The idea is to make it easy for the
committers to grab your patch and apply it.
--
* Greg Smith [email protected] http://www.gregsmith.com Baltimore, MD
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Improve pg_restore docs
2009-06-29 18:15 Improve pg_restore docs Mike Toews <[email protected]>
2009-06-29 18:25 ` Re: Improve pg_restore docs Greg Smith <[email protected]>
@ 2009-06-29 18:31 ` Mike Toews <[email protected]>
2009-06-29 18:34 ` Re: Improve pg_restore docs Greg Smith <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Mike Toews @ 2009-06-29 18:31 UTC (permalink / raw)
To: Greg Smith <[email protected]>; +Cc: pgsql-docs
Greg Smith wrote:
> The standard way to submit patches here is to attach a file with a
> full context diff (diff -c) to the message, rather than putting it
> inline or including just the changes. The idea is to make it easy for
> the committers to grab your patch and apply it.
Part of my hesitation in attaching the patch is that I'm on a Windows
computer (be aware of CRLF line endings in the attached). Apply to
pgsql/doc/src/sgml/ref/pg_restore.sgml
-Mike
291c291,292
< specific table.
---
> specific table. The default is taken from the
> <envar>default_path</envar> variable.
379c380,382
< Restore definition and/or data of named table only.
---
> Restore definition and/or data of named table only. This can be
> combined with the <option>-n</option> option to restore a table
> from a specific schema.
Attachments:
[text/plain] pg_restore.patch (407B, 2-pg_restore.patch)
download | inline diff:
291c291,292
< specific table.
---
> specific table. The default is taken from the
> <envar>default_path</envar> variable.
379c380,382
< Restore definition and/or data of named table only.
---
> Restore definition and/or data of named table only. This can be
> combined with the <option>-n</option> option to restore a table
> from a specific schema.
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Improve pg_restore docs
2009-06-29 18:15 Improve pg_restore docs Mike Toews <[email protected]>
2009-06-29 18:25 ` Re: Improve pg_restore docs Greg Smith <[email protected]>
2009-06-29 18:31 ` Re: Improve pg_restore docs Mike Toews <[email protected]>
@ 2009-06-29 18:34 ` Greg Smith <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Greg Smith @ 2009-06-29 18:34 UTC (permalink / raw)
To: Mike Toews <[email protected]>; +Cc: pgsql-docs
On Mon, 29 Jun 2009, Mike Toews wrote:
> Apply to pgsql/doc/src/sgml/ref/pg_restore.sgml
The main point I was trying to make is that we want the whole patch, not
just the change. A standard diff patch will include what file name it is
supposed to apply to as part of its header.
--
* Greg Smith [email protected] http://www.gregsmith.com Baltimore, MD
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Improve pg_restore docs
2009-06-29 18:15 Improve pg_restore docs Mike Toews <[email protected]>
@ 2010-02-24 16:28 ` Bruce Momjian <[email protected]>
1 sibling, 0 replies; 5+ messages in thread
From: Bruce Momjian @ 2010-02-24 16:28 UTC (permalink / raw)
To: Mike Toews <[email protected]>; +Cc: pgsql-docs
Mike Toews wrote:
> Hi,
>
> From a quick discussion on hackers
> (http://archives.postgresql.org/pgsql-hackers/2009-06/msg01434.php), it
> appears the documentation can improve for pg_restore.
>
> I've prepared some quick diff output from
> pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think
> would help. Note that I'm not entirely sure about the default namespace
> from default_path .. please verify this before accepting. Edit as necessary.
>
> 291c291,292
> < specific table.
> ---
> > specific table. The default is taken from the
> > <envar>default_path</envar> variable.
> 379c380,382
> < Restore definition and/or data of named table only.
> ---
> > Restore definition and/or data of named table only. This can be
> > combined with the <option>-n</option> option to restore a table
> > from a specific schema.
I have applied a modified version of your second change to our
documentation.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +
Attachments:
[text/x-diff] /rtmp/diff (1007B, 2-%2Frtmp%2Fdiff)
download | inline diff:
Index: doc/src/sgml/ref/pg_restore.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/pg_restore.sgml,v
retrieving revision 1.85
diff -c -c -r1.85 pg_restore.sgml
*** doc/src/sgml/ref/pg_restore.sgml 23 Feb 2010 00:21:19 -0000 1.85
--- doc/src/sgml/ref/pg_restore.sgml 24 Feb 2010 16:27:14 -0000
***************
*** 377,383 ****
<term><option>--table=<replaceable class="parameter">table</replaceable></option></term>
<listitem>
<para>
! Restore definition and/or data of named table only.
</para>
</listitem>
</varlistentry>
--- 377,384 ----
<term><option>--table=<replaceable class="parameter">table</replaceable></option></term>
<listitem>
<para>
! Restore definition and/or data of named table only. This can be
! combined with the <option>-n</option> option to specify a schema.
</para>
</listitem>
</varlistentry>
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2010-02-24 16:28 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-29 18:15 Improve pg_restore docs Mike Toews <[email protected]>
2009-06-29 18:25 ` Greg Smith <[email protected]>
2009-06-29 18:31 ` Mike Toews <[email protected]>
2009-06-29 18:34 ` Greg Smith <[email protected]>
2010-02-24 16:28 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox