pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
commit_delay and commit_siblings -- restart or reload?
3+ messages / 2 participants
[nested] [flat]

* commit_delay and commit_siblings -- restart or reload?
@ 2010-06-01 15:51  Joshua Tolley <eggyknap@gmail.com>
  0 siblings, 1 reply; 3+ messages in thread

From: Joshua Tolley @ 2010-06-01 15:51 UTC (permalink / raw)
  To: pgsql-docs

The documentation for commit_delay and commit_siblings doesn't mention whether
a reload or restart is required to set them. I recommend something like the
trivial attached docs patch to make it clear(er) that a reload is required.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

Attachments:

commit_delay.docs.patch (text/x-diff, 1.8K) download diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 48ad9f6..c513eba 100644 *** a/doc/src/sgml/config.sgml --- b/doc/src/sgml/config.sgml *************** SET ENABLE_SEQSCAN TO OFF; *** 1643,1649 **** commit. Therefore, the delay is only performed if at least <varname>commit_siblings</varname> other transactions are active at the instant that a server process has written its ! commit record. The default is zero (no delay). </para> </listitem> </varlistentry> --- 1643,1651 ---- commit. Therefore, the delay is only performed if at least <varname>commit_siblings</varname> other transactions are active at the instant that a server process has written its ! commit record. The default is zero (no delay). This parameter can only ! be set in the <filename>postgresql.conf</> file or on the server ! command line. </para> </listitem> </varlistentry> *************** SET ENABLE_SEQSCAN TO OFF; *** 1659,1665 **** before performing the <varname>commit_delay</> delay. A larger value makes it more probable that at least one other transaction will become ready to commit during the delay ! interval. The default is five transactions. </para> </listitem> </varlistentry> --- 1661,1669 ---- before performing the <varname>commit_delay</> delay. A larger value makes it more probable that at least one other transaction will become ready to commit during the delay ! interval. The default is five transactions. This parameter can only be ! set in the <filename>postgresql.conf</> file or on the server command ! line. </para> </listitem> </varlistentry>
signature.asc (application/pgp-signature, 196B) download ^ permalink raw reply [nested|flat] 3+ messages in thread

* Re: commit_delay and commit_siblings -- restart or reload?
@ 2010-06-01 19:33  Robert Haas <robertmhaas@gmail.com>
  parent: Joshua Tolley <eggyknap@gmail.com>
  0 siblings, 1 reply; 3+ messages in thread

From: Robert Haas @ 2010-06-01 19:33 UTC (permalink / raw)
  To: Joshua Tolley <eggyknap@gmail.com>; +Cc: pgsql-docs

On Tue, Jun 1, 2010 at 11:51 AM, Joshua Tolley <eggyknap@gmail.com> wrote:
> The documentation for commit_delay and commit_siblings doesn't mention whether
> a reload or restart is required to set them. I recommend something like the
> trivial attached docs patch to make it clear(er) that a reload is required.

These parameters are PGC_USERSET - a reload is not the only way to change them.

Of course, changing any parameter in postgresql.conf won't take effect
unless you reload, but the point of that sentence, in the other places
where we use it, is that you can't change those parameters using
things like ALTER DATABASE ... SET, ALTER USER ... SET, just plain
SET, etc.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: commit_delay and commit_siblings -- restart or reload?
@ 2010-06-01 21:50  Joshua Tolley <eggyknap@gmail.com>
  parent: Robert Haas <robertmhaas@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Joshua Tolley @ 2010-06-01 21:50 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-docs

On Tue, Jun 01, 2010 at 03:33:24PM -0400, Robert Haas wrote:
> On Tue, Jun 1, 2010 at 11:51 AM, Joshua Tolley <eggyknap@gmail.com> wrote:
> > The documentation for commit_delay and commit_siblings doesn't mention whether
> > a reload or restart is required to set them. I recommend something like the
> > trivial attached docs patch to make it clear(er) that a reload is required.
> 
> These parameters are PGC_USERSET - a reload is not the only way to change them.
> 
> Of course, changing any parameter in postgresql.conf won't take effect
> unless you reload, but the point of that sentence, in the other places
> where we use it, is that you can't change those parameters using
> things like ALTER DATABASE ... SET, ALTER USER ... SET, just plain
> SET, etc.

Ah, you're right. My mistake -- thanks.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

Attachments:

  signature.asc (application/pgp-signature, 196B) download

^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2010-06-01 21:50 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-06-01 15:51 commit_delay and commit_siblings -- restart or reload? Joshua Tolley <eggyknap@gmail.com>
2010-06-01 19:33 ` Robert Haas <robertmhaas@gmail.com>
2010-06-01 21:50   ` Joshua Tolley <eggyknap@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox