public inbox for [email protected]  
help / color / mirror / Atom feed
From: Vik Fearing <[email protected]>
To: MauMau <[email protected]>
To: PG Docs <[email protected]>
Subject: Re: pageinspect forks
Date: Sun, 10 Aug 2014 20:59:59 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <510823BF13464AAE872F0C81C194E86C@maumau>
References: <[email protected]>
	<510823BF13464AAE872F0C81C194E86C@maumau>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On 08/10/2014 03:24 PM, MauMau wrote:
> From: "Vik Fearing" <[email protected]>
>> I noticed that the documentation for pageinspect lists the different
>> forks but omits the initialization fork.
>>
>> Here is a trivial patch to fix that.
> 
> Could you also improve the doc by changing "table" to "relation" in the
> description of get_raw_page()?  Having a quick look at the code, it
> seems that the function can also handle indexes.
> 
>        table and returns a copy as a <type>bytea</> value.  This allows a


Good catch.  I wasn't sure whether using "relation" or "table or index"
was better, but after a quick test it seems it works for sequences, too,
so I've gone with "relation".

It doesn't work with views, of course, but it does work with
materialized views.

Modified patch attached.
-- 
Vik


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Attachments:

  [text/x-diff] pageinspect_init_fork.v2.patch (1.2K, 2-pageinspect_init_fork.v2.patch)
  download | inline diff:
*** a/doc/src/sgml/pageinspect.sgml
--- b/doc/src/sgml/pageinspect.sgml
***************
*** 28,38 ****
      <listitem>
       <para>
        <function>get_raw_page</function> reads the specified block of the named
!       table and returns a copy as a <type>bytea</> value.  This allows a
        single time-consistent copy of the block to be obtained.
        <replaceable>fork</replaceable> should be <literal>'main'</literal> for
!       the main data fork, or <literal>'fsm'</literal> for the free space map,
!       or <literal>'vm'</literal> for the visibility map.
       </para>
      </listitem>
     </varlistentry>
--- 28,39 ----
      <listitem>
       <para>
        <function>get_raw_page</function> reads the specified block of the named
!       relation and returns a copy as a <type>bytea</> value.  This allows a
        single time-consistent copy of the block to be obtained.
        <replaceable>fork</replaceable> should be <literal>'main'</literal> for
!       the main data fork, <literal>'fsm'</literal> for the free space map,
!       <literal>'vm'</literal> for the visibility map, or <literal>'init'</literal>
!       for the initialization fork.
       </para>
      </listitem>
     </varlistentry>


view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pageinspect forks
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox