public inbox for [email protected]  
help / color / mirror / Atom feed
From: Josh Berkus <[email protected]>
To: Tom Lane <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Kevin Grittner <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: MauMau <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Sample archive_command is still problematic
Date: Tue, 19 Aug 2014 10:19:34 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <WM!babf90da7866940a682481e46c386e7c69000c9a267ccfe19e97313775bb5606a68d4d2e6154337bfc31bd0d337be822!@asav-1.01.com>
References: <[email protected]>
	<[email protected]>
	<0F73426A2EA544878BCAC33BB989D671@maumau>
	<[email protected]>
	<[email protected]>
	<CABUevEwiaBWkgV+RX=Y77hauz-oKSo=7Tu7S7a8DN4dXGZSdTQ@mail.gmail.com>
	<WM!82507310e76be1df29048280e058916e28f087da5fbabb90b2b211e11d1cadd78895174bd7e489fa8d894cb824320620!@asav-2.01.com>
	<[email protected]>
	<[email protected]>
	<WM!babf90da7866940a682481e46c386e7c69000c9a267ccfe19e97313775bb5606a68d4d2e6154337bfc31bd0d337be822!@asav-1.01.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On 08/18/2014 10:31 AM, Tom Lane wrote:
> Josh Berkus <[email protected]> writes:
>> 2) One reason users are using the "test -f" version of the archive
>> command is that we put it in the same postgresql.conf.  I would suggest
>> that we don't put *any* archive command in the sample postgresql.conf,
>> since there is no command we can supply which isn't a potential foot-gun.
> 
> If you want to remove the last line of this:
> 
> #archive_command = ''		# command to use to archive a logfile segment
> 				# placeholders: %p = path of file to archive
> 				#               %f = file name only
> 				# e.g. 'test ! -f /mnt/server/archivedir/%f && cp %p /mnt/server/archivedir/%f'
> 
> I'm okay with that.  But if you want to remove the sample command from the
> SGML docs I'm going to push back a bit harder...

Well, if we want a sample command in the docs, then we should actually
give a few different sample commands and even a sample shell script.  If
we give the users several alternatives, maybe they'll actually think
about it instead of just C&P.

Make sense?

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



view thread (25+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Sample archive_command is still problematic
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox