public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pavel Luzanov <[email protected]>
To: [email protected]
Subject: Re: pg_monitor role description
Date: Thu, 20 May 2021 20:27:48 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CAOBaU_Y3b1Vet2UPDwjyi-pVv1wxT8fH4Fe4UKEZbZi6C-SGWQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>

Hello,

On 20.05.2021 19:03, Tom Lane wrote:

> Pavel Luzanov <[email protected]> writes:
>> Let me try one more time.
>> What is correct from the English language point of view:
>> 1. Julien Rouhaud is a member of PostgreSQL Community.
>> or
>> 2. PostgreSQL Community is a member of Julien Rouhaud, Michael Paquier.
>> Or both forms are correct?
>> I think that 1 is correct.
> You're right about that ...

So, is it correct to change description of pg_monitor role from:

"Read/execute various monitoring views and functions. This role is a member of|pg_read_all_settings|,|pg_read_all_stats|  and|pg_stat_scan_tables|."

to

"Read/execute various monitoring views and functions. The roles pg_read_all_settings, pg_read_all_stats and pg_stat_scan_tables are members of this role."

I can prepare a simple patch.

>> And column header in a \du output must be something like 'members' instead of 'member of'.
> ... but this does not follow, because it's a poor analogy.  "Member of"
> means "these role(s) have been GRANT'ed to pg_monitor".

Yes, I understood this point and agree.


-- 
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pg_monitor role description
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox