From: Euler Taveira <euler@eulerto.com>
To: Michael Paquier <michael@paquier.xyz>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: nikolai.berkoff <nikolai.berkoff@pm.me>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: Missing mention of autovacuum_work_mem
Date: Fri, 24 Sep 2021 12:21:40 -0300
Message-ID: <5e51539f-e4b6-4b46-b995-23a2c17252e8@www.fastmail.com> (raw)
In-Reply-To: <YUxUj38VIKsBPoa3@paquier.xyz>
References: <1kIqf6Q1G-wVkQkeg_BRSpcmy77hNfh9vlLQ3AF1APT-pKHRYT3z1IuDC5K2w83-4Qa016V1SfWJfF1v0Z0qf6141DbLcpIZJY3edlBEkCs=@pm.me>
<b48ec99bfbb9eaf329fd9c3e7a20551810244882.camel@cybertec.at>
<2a_0HzEWsHbu9VVZKMxdZ-YxVvFqamXG4crWy1xNkE4NIF-VjRuquYqzrNzmq8-2kJorJymk1D7CDbC2JgYA-BBGibPcxzWQ6R1WTtGMacE=@pm.me>
<e6deef8f-e165-4ba5-b48f-80ba8e2d4b51@www.fastmail.com>
<2806390d2974dc98598a60947395703dc1eead9a.camel@cybertec.at>
<YUxUj38VIKsBPoa3@paquier.xyz>
On Thu, Sep 23, 2021, at 7:18 AM, Michael Paquier wrote:
> On Thu, Sep 23, 2021 at 10:48:37AM +0200, Laurenz Albe wrote:
> > Thanks, and +1 from me.
>
> maintenance_work_mem would be used in the context of autovacuum if
> autovacuum_work_mem is -1, but it seems to me that the suggested
> wording sounds like only autovacuum_work_mem is used and that it would
> never fall back to maintenance_work_mem, no? I would suggest the
> addition of "if specified" in the new part within parenthesis
>
Good point. However, I prefer "if set".
--
Euler Taveira
EDB https://www.enterprisedb.com/Attachments:
[text/x-patch] v2-0001-Improve-vacumming-indexes-description.patch (1.5K, ../5e51539f-e4b6-4b46-b995-23a2c17252e8@www.fastmail.com/3-v2-0001-Improve-vacumming-indexes-description.patch)
download | inline diff:
From fb9672d58520f452b27f1747d2ed13ddf9f5658e Mon Sep 17 00:00:00 2001
From: Euler Taveira <euler.taveira@enterprisedb.com>
Date: Wed, 22 Sep 2021 14:47:12 -0300
Subject: [PATCH v2] Improve vacumming indexes description
Mention autovacuum_work_mem if VACUUM is run by autovacuum.
Reported-by: Nikolai Berkoff
Author: Laurenz Albe
Reviewed-by: Nikolai Berkoff, Michael Paquier, Euler Taveira
Discussion: https://postgr.es/m/1kIqf6Q1G-wVkQkeg_BRSpcmy77hNfh9vlLQ3AF1APT-pKHRYT3z1IuDC5K2w83-4Qa016V1SfWJfF1v0Z0qf6141DbLcpIZJY3edlBEkCs%3D%40pm.me
---
doc/src/sgml/monitoring.sgml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgmlindex 2281ba120f..c2f2a3a7a8 100644--- a/doc/src/sgml/monitoring.sgml+++ b/doc/src/sgml/monitoring.sgml@@ -6147,8 +6147,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<command>VACUUM</command> is currently vacuuming the indexes. If a table has
any indexes, this will happen at least once per vacuum, after the heap
has been completely scanned. It may happen multiple times per vacuum
- if <xref linkend="guc-maintenance-work-mem"/> is insufficient to- store the number of dead tuples found.+ if <xref linkend="guc-maintenance-work-mem"/> (or, in the case of autovacuum,+ <xref linkend="guc-autovacuum-work-mem"/>, if set) is insufficient to store+ the number of dead tuples found.
</entry>
</row>
<row>
--
2.20.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: euler@eulerto.com, michael@paquier.xyz, laurenz.albe@cybertec.at, nikolai.berkoff@pm.me, pgsql-docs@lists.postgresql.org
Subject: Re: Missing mention of autovacuum_work_mem
In-Reply-To: <5e51539f-e4b6-4b46-b995-23a2c17252e8@www.fastmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox