pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jonathan S. Katz <jkatz@postgresql.org>
To: Joe Conway <mail@joeconway.com>
To: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Steven Winfield <Steven.Winfield@cantabcapital.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Cc: Jonathan S. Katz <jonathan.katz@excoventures.com>
Subject: Re: SET ROLE documentation not entirely correct
Date: Thu, 25 Apr 2019 17:22:44 -0400
Message-ID: <6bd15afe-69ea-33b7-379a-f71fda68b427@postgresql.org> (raw)
In-Reply-To: <eb139a20-811b-91ed-fbe3-00968c614425@postgresql.org>
References: <155603476764.1372.10888362840885095061@wrigleys.postgresql.org>
	<03796ce5-8366-cd32-0436-9981ffbeb993@joeconway.com>
	<E9FA92C2921F31408041863B74EE4C2001BD62E4D4@CCPMAILDAG03.cantab.local>
	<c7dfb7a9-f9d9-245c-1b8a-4d5c1cea6a00@joeconway.com>
	<E9FA92C2921F31408041863B74EE4C2001BD62EB76@CCPMAILDAG03.cantab.local>
	<67c97dbc-9caf-aa7e-622a-e20b28b7e597@joeconway.com>
	<02e17cb3-f8a9-234f-f3ce-2b80bc49031d@joeconway.com>
	<26109.1556217198@sss.pgh.pa.us>
	<20190425190626.GY6197@tamriel.snowman.net>
	<97c6e8d5-7e51-5cd2-4fc2-652ad02659d9@joeconway.com>
	<eb139a20-811b-91ed-fbe3-00968c614425@postgresql.org>

On 4/25/19 4:52 PM, Jonathan S. Katz wrote:
> On 4/25/19 3:20 PM, Joe Conway wrote:
>> On 4/25/19 3:06 PM, Stephen Frost wrote:
>>> Greetings,
>>>
>>> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>>>> Joe Conway <mail@joeconway.com> writes:
>>>>> On 4/25/19 1:08 PM, Joe Conway wrote:
>>>>>> There is one image which can be used as an example though:
>>>>>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/storage.sgml;hb=HEAD
>>>>
>>>>> Here is a more precise URL:
>>>>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/storage.sgml;hb=HEAD#l934
>>>>
>>>> Comparing that to what I see at
>>>>
>>>> https://www.postgresql.org/docs/devel/storage-page-layout.html
>>>>
>>>> does not lead to a warm feeling about our images-in-docs stuff
>>>> really being ready for prime time.  It works OK in some browsers
>>>> but others (at least Safari) cut off the image.
>>>
>>> Yeah, I'm seeing it cut off in Chrome too, initially, and then it seems
>>> to fix itself if I resize the window down from 4k (and stay fixed even
>>> if I then go back to the original, much larger, size).  That seems like
>>> a CSS or layout issue though, not an issue with the image itself..?
>>
>>
>> Yeah, I see the same thing in Chrome -- maybe Jonathan has an idea what
>> is going on and how to best fix it?
> 
> See[1] - I'm not sure if the final piece is committed -- if when it is I
> can finish fixing the pgweb part
OK, so I took a quick look at the existing SVGs with my patched version
of pgweb.

The short answer is that it's better: the SVGs are not responsive, but
they are displaying. There still needs to be work on the SVGs as
indicated in that thread to make them responsive[1].

With that said, the pgweb patch does fix their current display at least
in full view, so I pushed the current patch to pgweb to do that. The fix
will take effect the next time the nightly docload runs, or if someone
on pginfra forces it to occur more quickly.

Thanks,

Jonathan

[1]
https://www.postgresql.org/message-id/flat/6d2442d1-84a2-36ef-e014-b6d1ece8a139%40postgresql.org

Attachments:

  [application/pgp-signature] signature.asc (832B, ../6bd15afe-69ea-33b7-379a-f71fda68b427@postgresql.org/2-signature.asc)
  download

view thread (23+ messages)  latest in thread

Message-ID: <6bd15afe-69ea-33b7-379a-f71fda68b427@postgresql.org>
Permalink:  ../6bd15afe-69ea-33b7-379a-f71fda68b427@postgresql.org/
Also on:    postgresql.org/message-id/6bd15afe-69ea-33b7-379a-f71fda68b427@postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: jkatz@postgresql.org, mail@joeconway.com, sfrost@snowman.net, tgl@sss.pgh.pa.us, Steven.Winfield@cantabcapital.com, pgsql-docs@lists.postgresql.org, jonathan.katz@excoventures.com
  Subject: Re: SET ROLE documentation not entirely correct
  In-Reply-To: <6bd15afe-69ea-33b7-379a-f71fda68b427@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox