From: Euler Taveira <euler@eulerto.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: nikolai.berkoff <nikolai.berkoff@pm.me>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: ALTER TABLE ... SET DATA TYPE removes statistics
Date: Fri, 22 Oct 2021 12:20:55 -0300
Message-ID: <6befff68-6293-4d75-9c66-72fe5596aa02@www.fastmail.com> (raw)
In-Reply-To: <202110191516.eufiqzha2etw@alvherre.pgsql>
References: <202110191516.eufiqzha2etw@alvherre.pgsql>
On Tue, Oct 19, 2021, at 12:16 PM, Alvaro Herrera wrote:
> On 2021-Oct-19, Michael Paquier wrote:
>
> > On Mon, Oct 18, 2021 at 05:15:59PM -0300, Euler Taveira wrote:
> > > I agree that it might surprise an user and it would be good to document it.
> > > However, it does not belong to the description. I would add it to the Notes
> > > section at the end of the ALTER TABLE page.
> >
> > No objections to the suggested addition and the location of the
> > addition (paragraph of SET DATA TYPE rather than "Notes"), but I think
> > that the phrasing could be better:
> > "The column's statistics are removed, hence a follow-up ANALYZE is
> > suited to update the statistics to the new column type."
>
> Dunno, putting it in the middle of the existing paragraph looks odd to
> me. I would put it in a separate one instead, as in the attached.
LGTM. I'm not sure if it is worth mentioning that the user needs to ANALYZE
only the removed column instead of the whole table. Anyway, it is good to have
statistics from the same snapshot.
--
Euler Taveira
EDB https://www.enterprisedb.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: euler@eulerto.com, alvherre@alvh.no-ip.org, michael@paquier.xyz, nikolai.berkoff@pm.me, pgsql-docs@lists.postgresql.org
Subject: Re: ALTER TABLE ... SET DATA TYPE removes statistics
In-Reply-To: <6befff68-6293-4d75-9c66-72fe5596aa02@www.fastmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox