public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Oleg <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: [email protected]
Subject: Re: Documentation improvement patch
Date: Thu, 30 Oct 2025 11:15:26 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 25.10.25 21:01, Oleg wrote:
> Dear Daniel,
> 
> Thank you for your prompt feedback.
> 
> Attached, please find the updated documentation patch, which 
> incorporates your suggestions from both the first and second rounds of 
> review.

       <term><literal>ALTER_REPLICATION_SLOT</literal> <replaceable 
class="parameter">slot_name</replaceable> ( <replaceable 
class="parameter">option</replaceable> [, ...] )
        <indexterm><primary>ALTER_REPLICATION_SLOT</primary></indexterm>
       </term>
       <listitem>
        <para>
-       Change the definition of a replication slot.
+       Changes the definition of a replication slot.

I think these are intentionally written in imperative style.  Compare 
the synopses of the main SQL commands: "change the definition of a 
domain" etc.

-     First, define a <literal>PgStat_KindInfo</literal> that includes all
+     First, define <literal>PgStat_KindInfo</literal> that includes all

I think this change is incorrect.  You are being asked to define an 
instance of PgStat_KindInfo, not PgStat_KindInfo itself (which already 
exists).

The remaining changes look ok to me.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Documentation improvement patch
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox